Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add port-forwarding to dev role too #5870

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Add port-forwarding to dev role too #5870

merged 1 commit into from
Dec 12, 2024

Conversation

danlysiak
Copy link
Member

@danlysiak danlysiak commented Dec 12, 2024 •
edited by github-actions bot
Loading

Change description

Follow-on to #5869 - add same permissions to dev role.

Testing done

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

🤖AEP PR SUMMARY🤖

  • dev-role.yaml
    • Added a new rule allowing the dev role to perform port forwarding for pods.

@danlysiak danlysiak requested a review from a team as a code owner December 12, 2024 15:27
@danlysiak danlysiak enabled auto-merge (squash) December 12, 2024 15:27
@danlysiak danlysiak merged commit 7b13254 into master Dec 12, 2024
18 checks passed
@danlysiak danlysiak deleted the danlysiak-patch-3 branch December 12, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endakelly endakelly endakelly approved these changes

@adulkoan-hmcts adulkoan-hmcts Awaiting requested review from adulkoan-hmcts adulkoan-hmcts is a code owner automatically assigned from hmcts/platform-operations

@roycohen1 roycohen1 Awaiting requested review from roycohen1 roycohen1 is a code owner automatically assigned from hmcts/platform-operations

@ieuanb74 ieuanb74 Awaiting requested review from ieuanb74 ieuanb74 is a code owner automatically assigned from hmcts/platform-operations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danlysiak @endakelly