Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #EXUI-2656: passport js rollout needs serviceOverride flag #259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: #EXUI-2656: passport js rollout needs serviceOverride flag #259

wants to merge 1 commit into from

Conversation

MunishSharmaHMCTS
Copy link
Contributor

@MunishSharmaHMCTS MunishSharmaHMCTS commented Dec 19, 2024 •
edited
Loading

Jira link

https://tools.hmcts.net/jira/browse/EXUI-2656

Change description

Rollout for passportjs upgrade

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@MunishSharmaHMCTS MunishSharmaHMCTS changed the title #EXUI-2656: passport js rollout needs serviceOverride flag fix: #EXUI-2656: passport js rollout needs serviceOverride flag Dec 19, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

connorpgpmcelroy
connorpgpmcelroy approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@connorpgpmcelroy connorpgpmcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StoneBenHMCTS StoneBenHMCTS StoneBenHMCTS approved these changes

@connorpgpmcelroy connorpgpmcelroy connorpgpmcelroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MunishSharmaHMCTS @connorpgpmcelroy @StoneBenHMCTS