DFPL-2546 Refuge Address option for Respondent/Other persons Journeys #5755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit afee204.
github-actions
bot
added
the
ccd configuration
This reverts commit afee204.
| // Flag for preventing from purging the converted old field value during deserialization if addressKnowV2 is null | ||
| @Builder.Default | ||
| @Getter(AccessLevel.NONE) | ||
| private final boolean isConvertedAddressKnow = false; |
There was a problem hiding this comment.
Does this get used? Can see it's also defined on 173
There was a problem hiding this comment.
it won't get serialised to Json, as @Getter(AccessLevel.NONE) mean no getter is generated for this field.
And it is only being used as internal flag when building the object
There was a problem hiding this comment.
oh! right, that one in builder is redundant
There was a problem hiding this comment.
My bad, not that one in the builder, this one is redundant. Just did some simple test, that one in builder is thread safe. so should be fine
jamesrferguson1
previously approved these changes
Dec 6, 2024
* DFPL-2641: Move address known type to the confidential tab * DFPL-2641: Refactor conversion tests, temp dupe function for others as incompatible due to UUIDs for firstOther * DFPL-2641: Fix controller test * DFPL-2641: Fix test - everyone was named James, clashing with new code... * DFPL-2641: Fix test * DFPL-2641: Fix test * DFPL-2641: Fix test
…5796) Co-authored-by: prabhamuthu15 <[email protected]>
jamesrferguson1
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DFPL-2546
Change description
Refuge Address option for Respondent/Other persons Journeys.
#5696 Release failed as the pipeline failed to import CCD definition. The ticket was rolled back.
Error message was:
ElasticSearch initialisation exception" mapper [data.hearingDetails.value.others.value.addressKnow] cannot be changed from type [keyword] to [text]This PR fix the issue by introducing a new field "addressKnowV2" insetad of updating the type of the existing "addressKnow" field
The old field is deprecated, and the application will convert the old field to new field during case data deserialisation.
Does this PR introduce a breaking change? (check one with "x")