Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie banner changes for ISDB-596 #92

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Jenkinsfile_CNP
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#!groovy
import uk.gov.hmcts.contino.GithubAPI

@Library("Infrastructure")

Expand All @@ -14,5 +15,14 @@ withPipeline(type, product, component) {
afterAlways('build') {
yarnBuilder.yarn('build')
}

onPR() {
env.ENV = 'preview'
// enableCleanupOfHelmReleaseOnSuccess()
def githubApi = new GithubAPI(this)
if (!githubApi.getLabelsbyPattern(env.BRANCH_NAME, "keep-helm")) {
enableCleanupOfHelmReleaseOnSuccess()
}
}

}
2 changes: 1 addition & 1 deletion config/default.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ session:
host:
key:
api:
cos: 'https://fis-cos-api-pr-161.service.core-compute-preview.internal'
cos: 'https://fis-cos-api-pr-165.service.core-compute-preview.internal'
serviceAuth: 'http://rpe-service-auth-provider-aat.service.core-compute-aat.internal'
uploadPolicy:
documentSize: 20
Expand Down
2 changes: 1 addition & 1 deletion config/development.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ session:
host:
key:
api:
cos: 'https://fis-cos-api-pr-161.service.core-compute-preview.internal'
cos: 'https://fis-cos-api-pr-165.service.core-compute-preview.internal'
serviceAuth: 'http://rpe-service-auth-provider-aat.service.core-compute-aat.internal'
uploadPolicy:
documentSize: 20
Expand Down
2 changes: 2 additions & 0 deletions src/main/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import { Helmet } from './modules/helmet';
import { LanguageToggle } from './modules/i18n';
import { Nunjucks } from './modules/nunjucks';
import { PropertiesVolume } from './modules/properties-volume';
import { Webpack } from './modules/webpack';
import { Routes } from './routes';
import { SessionStorage } from './settings/redis/redis';

Expand All @@ -39,6 +40,7 @@ new HealthCheck().enableFor(app);
new ErrorHandler().enableFor(app, logger);
new ErrorHandler().handleNextErrorsFor(app);
new Nunjucks().enableFor(app);
new Webpack().enableFor(app);
app.locals.developmentMode = process.env.NODE_ENV !== 'production';
app.use(favicon(path.join(__dirname, '/public/assets/images/favicon.ico')));
app.use(bodyParser.json() as RequestHandler);
Expand Down
2 changes: 1 addition & 1 deletion src/main/steps/common/webpack/js-template.njk
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<script src="/<%= htmlWebpackPlugin.files.js[0].substr(htmlWebpackPlugin.files.publicPath.length) %>"></script>
<script src="/test.js"></script>
<script src="/cookie.js"></script>
2 changes: 1 addition & 1 deletion src/main/steps/common/webpack/js.njk
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<script src="/main-dev.js"></script>
<script src="/test.js"></script>
<script src="/cookie.js"></script>
2 changes: 1 addition & 1 deletion src/main/steps/cookie-banner/template.njk
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<p>{{ cookiesLine2 }}</p>
{% endset %}

<div class="global-cookie-message" id="cm-cookie-banner" >
<div class="global-cookie-message" id="cm-cookie-banner" hidden >
{{ govukCookieBanner({
ariaLabel: cookiesHeading + " " + serviceName,
messages: [
Expand Down
2 changes: 1 addition & 1 deletion src/main/steps/urls.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export const SAVE_AND_SIGN_OUT: PageLink = '/save-and-sign-out';
export const TIMED_OUT_URL: PageLink = '/timed-out';
export const KEEP_ALIVE_URL: PageLink = '/keep-alive';
export const CSRF_TOKEN_ERROR_URL: PageLink = '/csrf-token-error';
export const CASE_SEARCH_URL: PageLink = '/edgecase/casefinder';
export const CASE_SEARCH_URL: PageLink = '/edgeCase/casefinder';
export const SERVICE_TYPE: PageLink = '/service-type';
export const DASHBOARD_URL: PageLink = '/dashboard';
export const ELIGIBILITY_URL: PageLink = '/eligibility';
Expand Down
2 changes: 1 addition & 1 deletion src/main/steps/webpack/js-template.njk
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<script src="/<%= htmlWebpackPlugin.files.js[0].substr(htmlWebpackPlugin.files.publicPath.length) %>"></script>
<script src="/test.js"></script>
<script src="/cookie.js"></script>
2 changes: 1 addition & 1 deletion src/main/steps/webpack/js.njk
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<script src="main-dev.js"></script>
<script src="test.js"></script>
<script src="cookie.js"></script>
2 changes: 1 addition & 1 deletion src/main/views/webpack/js-template.njk
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<script src="/<%= htmlWebpackPlugin.files.js[0].substr(htmlWebpackPlugin.files.publicPath.length) %>"></script>
<script src="/test.js"></script>
<script src="/cookie.js"></script>
2 changes: 1 addition & 1 deletion src/main/views/webpack/js.njk
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<script src="main-dev.js"></script>
<script src="test.js"></script>
<script src="cookie.js"></script>

210 changes: 141 additions & 69 deletions yarn.lock

Large diffs are not rendered by default.