Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dtspo 22631 - custom settings per aks cluster on SDS #658

Merged
merged 54 commits into from
Dec 11, 2024

Conversation

NickAzureDevops
Copy link
Contributor

@NickAzureDevops NickAzureDevops commented Dec 5, 2024

Jira link

See DTSPO-22631

Description

add custom settings per aks cluster on SDS. make it simliar to cft here hmcts/aks-cft-deploy#687

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

yes works on aks-cft-deploy pipeline

Issues Found

Please list any issues found during testing and how they were resolved:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Deployment Steps

None

Additional Information

Please add any other information that is important to this PR, such as screenshots, logs, or links to other related PRs.

https://dev.azure.com/hmcts/PlatformOperations/_build/results?buildId=710530&view=results

@hmcts-platform-operations

Plan Result (Genesis_sbox - Genesis)

No changes. Your infrastructure matches the configuration.

@hmcts-platform-operations

Plan Result (Network_sbox - NetworkRg)

No changes. Your infrastructure matches the configuration.

@hmcts-platform-operations

Plan Result (Network_sbox - DeployInfrastructure)

No changes. Your infrastructure matches the configuration.

@hmcts-platform-operations

Plan Result (Managed_Identity_sbox - Managed_Identity)

Plan: 0 to add, 1 to change, 0 to destroy.
  • Update
    • azurerm_resource_group.application-mi
Change Result (Click me)
  # azurerm_resource_group.application-mi will be updated in-place
  ~ resource "azurerm_resource_group" "application-mi" {
        id         = "/subscriptions/a8140a9e-f1b0-481f-a4de-09e2ee23f7ab/resourceGroups/managed-identities-sbox-rg"
        name       = "managed-identities-sbox-rg"
      ~ tags       = {
          + "application"  = "core"
          + "builtFrom"    = "hmcts/aks-sds-deploy"
          + "businessArea" = "Cross-Cutting"
          + "criticality"  = "Low"
          + "environment"  = "sandbox"
          + "expiresAfter" = "3000-01-01"
          + "startupMode"  = "always"
        }
        # (2 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

⚠️ Errors

@hmcts-platform-operations
Copy link

hmcts-platform-operations commented Dec 5, 2024

Plan Result (Aks_sbox - DeployInfrastructure)

Plan: 2 to add, 1 to change, 0 to destroy.
  • Create
    • azurerm_resource_group.disks_resource_group
    • azurerm_role_assignment.disk
  • Update
    • azapi_resource.managedCluster[0]
Change Result (Click me)
  # azapi_resource.managedCluster[0] will be updated in-place
  ~ resource "azapi_resource" "managedCluster" {
        id                        = "/subscriptions/a8140a9e-f1b0-481f-a4de-09e2ee23f7ab/resourceGroups/ss-sbox-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-sbox-01-aks"
        name                      = "ss-sbox-01-aks"
      ~ output                    = jsonencode({}) -> (known after apply)
      - tags                      = {
          - "application"  = "core"
          - "builtFrom"    = "hmcts/aks-sds-deploy"
          - "businessArea" = "Cross-Cutting"
          - "environment"  = "sandbox"
          - "expiresAfter" = "3000-01-01"
        } -> null
        # (8 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # azurerm_resource_group.disks_resource_group will be created
  + resource "azurerm_resource_group" "disks_resource_group" {
      + id       = (known after apply)
      + location = "uksouth"
      + name     = "disks-sbox-rg"
      + tags     = {
          + "application"  = "core"
          + "autoShutdown" = "true"
          + "builtFrom"    = "hmcts/aks-sds-deploy"
          + "businessArea" = "Cross-Cutting"
          + "criticality"  = "Low"
          + "environment"  = "sandbox"
          + "expiresAfter" = "3000-01-01"
        }
    }

  # azurerm_role_assignment.disk will be created
  + resource "azurerm_role_assignment" "disk" {
      + id                               = (known after apply)
      + name                             = (known after apply)
      + principal_id                     = "ba206872-8722-4375-bf4d-a28c39dff414"
      + principal_type                   = (known after apply)
      + role_definition_id               = (known after apply)
      + role_definition_name             = "Virtual Machine Contributor"
      + scope                            = (known after apply)
      + skip_service_principal_aad_check = (known after apply)
    }

Plan: 2 to add, 1 to change, 0 to destroy.
ℹ️ Objects have changed outside of Terraform

This feature was introduced from Terraform v0.15.4.

Terraform detected the following changes made outside of Terraform since the
last "terraform apply" which may have affected this plan:

  # azurerm_resource_group.disks_resource_group has been deleted
  - resource "azurerm_resource_group" "disks_resource_group" {
      - id         = "/subscriptions/a8140a9e-f1b0-481f-a4de-09e2ee23f7ab/resourceGroups/disks-sbox-rg" -> null
        name       = "disks-sbox-rg"
        tags       = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Low"
            "environment"  = "sandbox"
            "expiresAfter" = "3000-01-01"
        }
        # (2 unchanged attributes hidden)
    }


Unless you have made equivalent changes to your configuration, or ignored the

@hmcts-platform-operations

Plan Result (Genesis_ptlsbox - Genesis)

No changes. Your infrastructure matches the configuration.

@hmcts-platform-operations

Plan Result (Genesis_ithc - Genesis)

No changes. Your infrastructure matches the configuration.

@hmcts-platform-operations

Plan Result (Genesis_stg - Genesis)

No changes. Your infrastructure matches the configuration.

@hmcts-platform-operations

Plan Result (Genesis_demo - Genesis)

No changes. Your infrastructure matches the configuration.

@hmcts-platform-operations

Plan Result (Genesis_dev - Genesis)

No changes. Your infrastructure matches the configuration.

@NickAzureDevops NickAzureDevops merged commit 0505ed1 into master Dec 11, 2024
59 checks passed
@NickAzureDevops NickAzureDevops deleted the DTSPO-22631-Custom-settings-per-AKS-cluster branch December 11, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aks_demo - DeployInfrastructure/add-or-update Aks_dev - DeployInfrastructure/add-or-update Aks_ithc - DeployInfrastructure/add-or-update Aks_prod - DeployInfrastructure/add-or-update Aks_ptl - DeployInfrastructure/add-or-update Aks_ptlsbox - DeployInfrastructure/add-or-update Aks_sbox - DeployInfrastructure/add-or-update Aks_stg - DeployInfrastructure/add-or-update Aks_test - DeployInfrastructure/add-or-update Genesis_demo - Genesis/no-changes Genesis_dev - Genesis/no-changes Genesis_ithc - Genesis/no-changes Genesis_prod - Genesis/no-changes Genesis_ptl - Genesis/no-changes Genesis_ptlsbox - Genesis/no-changes Genesis_sbox - Genesis/no-changes Genesis_stg - Genesis/no-changes Genesis_test - Genesis/no-changes Managed_Identity_dev - Managed_Identity/no-changes Network_demo - DeployInfrastructure/no-changes Network_demo - NetworkRg/no-changes Network_dev - DeployInfrastructure/no-changes Network_dev - NetworkRg/no-changes Network_ithc - DeployInfrastructure/no-changes Network_ithc - NetworkRg/no-changes Network_prod - DeployInfrastructure/no-changes Network_prod - NetworkRg/no-changes Network_ptl - DeployInfrastructure/no-changes Network_ptl - NetworkRg/no-changes Network_ptlsbox - DeployInfrastructure/no-changes Network_ptlsbox - NetworkRg/no-changes Network_sbox - DeployInfrastructure/no-changes Network_sbox - NetworkRg/no-changes Network_stg - DeployInfrastructure/no-changes Network_stg - NetworkRg/no-changes Network_test - DeployInfrastructure/no-changes Network_test - NetworkRg/no-changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants