Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add AEP #582

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add AEP #582

wants to merge 1 commit into from

Conversation

thomast1906
Copy link
Contributor

@thomast1906 thomast1906 commented May 9, 2024 •
edited by github-actions bot
Loading

Change description

add AEP

🤖AEP PR SUMMARY🤖

.github/workflows/pr-reviewer.yml

  • Added a new file pr-reviewer.yml for CI PR Reviewer Pipeline.
  • Specifies trigger conditions for the workflow, sets environment variables, checks out the code, creates a diff file, generates a response, saves the response as response.md, and posts a comment in the pull request with the response.

.github/workflows/pr-summary.yml

  • Added a new file pr-summary.yml for CI PR Summary Pipeline.
  • Specifies trigger conditions for the workflow, sets environment variables, checks out the code, creates a diff file, generates a response, saves the response as response.md, and updates the pull request body with the response.

@thomast1906 thomast1906 requested a review from a team as a code owner May 9, 2024 12:19
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

General Suggestions

Use Specific Runner Version

  • You've opted to use runs-on: ubuntu-latest. To ensure the consistency and reliability of your workflows, it's recommended to use a specific version instead. For example, runs-on: ubuntu-20.04. This will prevent potential issues arising from unexpected changes in the latest version.

Improve Secret Management

  • Secrets like X_API_KEY and X_API_CONSUMER are rightly used, but ensure they have minimal scope and are rotated regularly. Avoid broad access wherever possible.

Error Handling and Logging

  • Ensure that you have comprehensive error handling and logging in place. Use specific error messages and consider sending notifications for job failures or critical errors.

YAML Syntax Best Practices

  • Use descriptive names for jobs, steps, and IDs that clearly explain their purpose or action.

Security Practices

  • Ensure that the external API endpoint (API_HOST) follows best security practices, such as HTTPS (you've done this, which is good), API rate limiting, and authentication mechanisms.

Echo Response

  • It appears you're echoing the entire response which includes headers. Be cautious of exposing sensitive information in logs. Consider logging only necessary information.

Specific Code Suggestions

Consistent Environment Variable Usage

  • You have mixed casing in environment variable access. For example, WORKING_DIRECTORY is accessed as both ${{ env.working_directory }} and ${{ github.workspace }}/. Keep the casing consistent to avoid confusion, preferably all uppercase to follow convention.

File Handling

  • When working with files, particularly those created during the run (diff.txt, response.md), ensure you're handling potential race conditions or failures. Consider adding checks before operations involving these files.

Redundant Command and Markdown Manipulation

  • The sequence of sed commands used to manipulate the API response body seems overly complicated. Consider if the API can return the data in a more suitable format or if the processing can be simplified.

Use GitHub Contexts More Effectively

yaml

  • uses: actions/github-script@v6
    with:
    script: |
    const prBody = context.payload.pull_request.body || '';
    const updatedBody = prBody.includes('...') ? prBody.replace(/.../...) : prBody + '\n\n...';
    // ...
- This can be improved for readability. Also, ensure that you're handling the case where `prBody.includes` checks for the presence of a specific marker or content correctly. The placeholder syntax (`...`) should be replaced with actual logic or removed if not used.

### Git Diff Command
- The command `git diff origin/master.remotes/origin/${{ github.head_ref }} > ${{ env.working_directory }}diff.txt` seems incorrect. The typical syntax doesn't require `.remotes/origin/` in the branch name. Verify if `origin/master...${{ github.head_ref }}` suffices.

### Conditional Commands Execution
- Consider adding more conditions or checks before proceeding with critical steps, such as generating a response to the API call, to ensure that all prerequisite conditions are met.

### Environment Variables in Scripts
- When passing environment variables to scripts, ensure they're correctly used and validated within the script for expected values to avoid potential runtime errors.

### Documentation
- Adding comments within the workflow file can greatly aid in understanding the purpose and functionality of each step for future maintainers.

The suggestions provided aim to enhance the readability, maintainability, and security of your GitHub Actions workflow.

@hmcts-platform-operations
Copy link

Plan Result (Genesis_sbox)

No changes. Your infrastructure matches the configuration.

@hmcts-platform-operations
Copy link

Plan Result (Network_sbox)

No changes. Your infrastructure matches the configuration.

@hmcts-platform-operations
Copy link

Plan Result (Managed_Identity_sbox)

Plan: 0 to add, 1 to change, 0 to destroy.
  • Update
    • azurerm_resource_group.application-mi
Change Result (Click me) 
  # azurerm_resource_group.application-mi will be updated in-place
  ~ resource "azurerm_resource_group" "application-mi" {
        id         = "/subscriptions/a8140a9e-f1b0-481f-a4de-09e2ee23f7ab/resourceGroups/managed-identities-sbox-rg"
        name       = "managed-identities-sbox-rg"
      ~ tags       = {
          + "application"  = "core"
          + "builtFrom"    = "hmcts/aks-sds-deploy"
          + "businessArea" = "Cross-Cutting"
          + "criticality"  = "Low"
          + "environment"  = "sandbox"
          + "expiresAfter" = "3000-01-01"
          + "startupMode"  = "always"
        }
        # (2 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

@hmcts-platform-operations
Copy link

Plan Result (Aks_sbox)

Plan: 0 to add, 10 to change, 0 to destroy.
  • Update
    • module.kubernetes["00"].azurerm_kubernetes_cluster.kubernetes_cluster
    • module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["arm"]
    • module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["cronjob"]
    • module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["linux"]
    • module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["msnode"]
    • module.kubernetes["01"].azurerm_kubernetes_cluster.kubernetes_cluster
    • module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["arm"]
    • module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["cronjob"]
    • module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["linux"]
    • module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["msnode"]
Change Result (Click me) 
  # module.kubernetes["00"].azurerm_kubernetes_cluster.kubernetes_cluster will be updated in-place
  ~ resource "azurerm_kubernetes_cluster" "kubernetes_cluster" {
        id                                  = "/subscriptions/a8140a9e-f1b0-481f-a4de-09e2ee23f7ab/resourceGroups/ss-sbox-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-sbox-00-aks"
      ~ kubernetes_version                  = "1.29.4" -> "1.29"
        name                                = "ss-sbox-00-aks"
        tags                                = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Low"
            "environment"  = "sandbox"
            "expiresAfter" = "3000-01-01"
        }
        # (36 unchanged attributes hidden)

      ~ default_node_pool {
            name                          = "system"
          ~ orchestrator_version          = "1.29.4" -> "1.29"
            tags                          = {
                "application"  = "core"
                "autoShutdown" = "true"
                "builtFrom"    = "hmcts/aks-sds-deploy"
                "businessArea" = "Cross-Cutting"
                "criticality"  = "Low"
                "environment"  = "sandbox"
                "expiresAfter" = "3000-01-01"
            }
            # (31 unchanged attributes hidden)

            # (1 unchanged block hidden)
        }

        # (9 unchanged blocks hidden)
    }

  # module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["arm"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/a8140a9e-f1b0-481f-a4de-09e2ee23f7ab/resourceGroups/ss-sbox-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-sbox-00-aks/agentPools/arm"
        name                          = "arm"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Low"
            "environment"  = "sandbox"
            "expiresAfter" = "3000-01-01"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["cronjob"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/a8140a9e-f1b0-481f-a4de-09e2ee23f7ab/resourceGroups/ss-sbox-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-sbox-00-aks/agentPools/cronjob"
        name                          = "cronjob"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Low"
            "environment"  = "sandbox"
            "expiresAfter" = "3000-01-01"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["linux"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/a8140a9e-f1b0-481f-a4de-09e2ee23f7ab/resourceGroups/ss-sbox-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-sbox-00-aks/agentPools/linux"
        name                          = "linux"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Low"
            "environment"  = "sandbox"
            "expiresAfter" = "3000-01-01"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["msnode"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/a8140a9e-f1b0-481f-a4de-09e2ee23f7ab/resourceGroups/ss-sbox-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-sbox-00-aks/agentPools/msnode"
        name                          = "msnode"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Low"
            "environment"  = "sandbox"
            "expiresAfter" = "3000-01-01"
        }
        # (32 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

  # module.kubernetes["01"].azurerm_kubernetes_cluster.kubernetes_cluster will be updated in-place
  ~ resource "azurerm_kubernetes_cluster" "kubernetes_cluster" {
        id                                  = "/subscriptions/a8140a9e-f1b0-481f-a4de-09e2ee23f7ab/resourceGroups/ss-sbox-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-sbox-01-aks"
      ~ kubernetes_version                  = "1.29.4" -> "1.29"
        name                                = "ss-sbox-01-aks"
        tags                                = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Low"
            "environment"  = "sandbox"
            "expiresAfter" = "3000-01-01"
        }
        # (36 unchanged attributes hidden)

      ~ default_node_pool {
            name                          = "system"
          ~ orchestrator_version          = "1.29.4" -> "1.29"
            tags                          = {
                "application"  = "core"
                "autoShutdown" = "true"
                "builtFrom"    = "hmcts/aks-sds-deploy"
                "businessArea" = "Cross-Cutting"
                "criticality"  = "Low"
                "environment"  = "sandbox"
                "expiresAfter" = "3000-01-01"
            }
            # (31 unchanged attributes hidden)

            # (1 unchanged block hidden)
        }

        # (9 unchanged blocks hidden)
    }

  # module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["arm"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/a8140a9e-f1b0-481f-a4de-09e2ee23f7ab/resourceGroups/ss-sbox-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-sbox-01-aks/agentPools/arm"
        name                          = "arm"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Low"
            "environment"  = "sandbox"
            "expiresAfter" = "3000-01-01"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["cronjob"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/a8140a9e-f1b0-481f-a4de-09e2ee23f7ab/resourceGroups/ss-sbox-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-sbox-01-aks/agentPools/cronjob"
        name                          = "cronjob"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Low"
            "environment"  = "sandbox"
            "expiresAfter" = "3000-01-01"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["linux"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/a8140a9e-f1b0-481f-a4de-09e2ee23f7ab/resourceGroups/ss-sbox-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-sbox-01-aks/agentPools/linux"
        name                          = "linux"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Low"
            "environment"  = "sandbox"
            "expiresAfter" = "3000-01-01"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["msnode"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/a8140a9e-f1b0-481f-a4de-09e2ee23f7ab/resourceGroups/ss-sbox-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-sbox-01-aks/agentPools/msnode"
        name                          = "msnode"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Low"
            "environment"  = "sandbox"
            "expiresAfter" = "3000-01-01"
        }
        # (32 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 10 to change, 0 to destroy.

@hmcts-platform-operations
Copy link

Plan Result (Genesis_ithc)

No changes. Your infrastructure matches the configuration.

@hmcts-platform-operations
Copy link

Plan Result (Genesis_ptlsbox)

No changes. Your infrastructure matches the configuration.

@hmcts-platform-operations
Copy link

Plan Result (Genesis_test)

No changes. Your infrastructure matches the configuration.

@hmcts-platform-operations
Copy link

Plan Result (Genesis_stg)

No changes. Your infrastructure matches the configuration.

@hmcts-platform-operations
Copy link

Plan Result (Genesis_demo)

No changes. Your infrastructure matches the configuration.

@hmcts-platform-operations
Copy link

Plan Result (Genesis_dev)

No changes. Your infrastructure matches the configuration.

@hmcts-platform-operations
Copy link

Plan Result (Network_ithc)

No changes. Your infrastructure matches the configuration.

@hmcts-platform-operations
Copy link

Plan Result (Managed_Identity_dev)

No changes. Your infrastructure matches the configuration.

@hmcts-platform-operations
Copy link

Plan Result (Aks_stg)

Plan: 0 to add, 8 to change, 0 to destroy.
  • Update
    • module.kubernetes["00"].azurerm_kubernetes_cluster.kubernetes_cluster
    • module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["cronjob"]
    • module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["linux"]
    • module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["msnode"]
    • module.kubernetes["01"].azurerm_kubernetes_cluster.kubernetes_cluster
    • module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["cronjob"]
    • module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["linux"]
    • module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["msnode"]
Change Result (Click me) 
  # module.kubernetes["00"].azurerm_kubernetes_cluster.kubernetes_cluster will be updated in-place
  ~ resource "azurerm_kubernetes_cluster" "kubernetes_cluster" {
        id                                  = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/ss-stg-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-stg-00-aks"
      ~ kubernetes_version                  = "1.29.4" -> "1.29"
        name                                = "ss-stg-00-aks"
        tags                                = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "High"
            "environment"  = "staging"
        }
        # (35 unchanged attributes hidden)

      ~ default_node_pool {
            name                          = "system"
          ~ orchestrator_version          = "1.29.4" -> "1.29"
            tags                          = {
                "application"  = "core"
                "autoShutdown" = "true"
                "builtFrom"    = "hmcts/aks-sds-deploy"
                "businessArea" = "Cross-Cutting"
                "criticality"  = "High"
                "environment"  = "staging"
            }
            # (31 unchanged attributes hidden)

            # (1 unchanged block hidden)
        }

        # (8 unchanged blocks hidden)
    }

  # module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["cronjob"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/ss-stg-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-stg-00-aks/agentPools/cronjob"
        name                          = "cronjob"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "High"
            "environment"  = "staging"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["linux"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/ss-stg-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-stg-00-aks/agentPools/linux"
        name                          = "linux"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "High"
            "environment"  = "staging"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["msnode"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/ss-stg-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-stg-00-aks/agentPools/msnode"
        name                          = "msnode"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "High"
            "environment"  = "staging"
        }
        # (32 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

  # module.kubernetes["01"].azurerm_kubernetes_cluster.kubernetes_cluster will be updated in-place
  ~ resource "azurerm_kubernetes_cluster" "kubernetes_cluster" {
        id                                  = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/ss-stg-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-stg-01-aks"
      ~ kubernetes_version                  = "1.29.4" -> "1.29"
        name                                = "ss-stg-01-aks"
        tags                                = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "High"
            "environment"  = "staging"
        }
        # (35 unchanged attributes hidden)

      ~ default_node_pool {
            name                          = "system"
          ~ orchestrator_version          = "1.29.4" -> "1.29"
            tags                          = {
                "application"  = "core"
                "autoShutdown" = "true"
                "builtFrom"    = "hmcts/aks-sds-deploy"
                "businessArea" = "Cross-Cutting"
                "criticality"  = "High"
                "environment"  = "staging"
            }
            # (31 unchanged attributes hidden)

            # (1 unchanged block hidden)
        }

        # (8 unchanged blocks hidden)
    }

  # module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["cronjob"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/ss-stg-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-stg-01-aks/agentPools/cronjob"
        name                          = "cronjob"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "High"
            "environment"  = "staging"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["linux"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/ss-stg-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-stg-01-aks/agentPools/linux"
        name                          = "linux"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "High"
            "environment"  = "staging"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["msnode"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/ss-stg-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-stg-01-aks/agentPools/msnode"
        name                          = "msnode"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "High"
            "environment"  = "staging"
        }
        # (32 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 8 to change, 0 to destroy.

@hmcts-platform-operations
Copy link

Plan Result (Aks_ptlsbox)

Plan: 0 to add, 3 to change, 0 to destroy.
  • Update
    • module.kubernetes["00"].azurerm_kubernetes_cluster.kubernetes_cluster
    • module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["cronjob"]
    • module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["linux"]
Change Result (Click me) 
  # module.kubernetes["00"].azurerm_kubernetes_cluster.kubernetes_cluster will be updated in-place
  ~ resource "azurerm_kubernetes_cluster" "kubernetes_cluster" {
      ~ azure_policy_enabled                = true -> false
        id                                  = "/subscriptions/64b1c6d6-1481-44ad-b620-d8fe26a2c768/resourceGroups/ss-ptlsbox-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-ptlsbox-00-aks"
      ~ kubernetes_version                  = "1.29.4" -> "1.29"
        name                                = "ss-ptlsbox-00-aks"
        tags                                = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Low"
            "environment"  = "sandbox"
            "expiresAfter" = "3000-01-01"
        }
        # (34 unchanged attributes hidden)

      ~ default_node_pool {
            name                          = "system"
          ~ orchestrator_version          = "1.29.4" -> "1.29"
            tags                          = {
                "application"  = "core"
                "autoShutdown" = "true"
                "builtFrom"    = "hmcts/aks-sds-deploy"
                "businessArea" = "Cross-Cutting"
                "criticality"  = "Low"
                "environment"  = "sandbox"
                "expiresAfter" = "3000-01-01"
            }
            # (31 unchanged attributes hidden)

            # (1 unchanged block hidden)
        }

        # (8 unchanged blocks hidden)
    }

  # module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["cronjob"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/64b1c6d6-1481-44ad-b620-d8fe26a2c768/resourceGroups/ss-ptlsbox-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-ptlsbox-00-aks/agentPools/cronjob"
        name                          = "cronjob"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Low"
            "environment"  = "sandbox"
            "expiresAfter" = "3000-01-01"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["linux"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/64b1c6d6-1481-44ad-b620-d8fe26a2c768/resourceGroups/ss-ptlsbox-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-ptlsbox-00-aks/agentPools/linux"
        name                          = "linux"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Low"
            "environment"  = "sandbox"
            "expiresAfter" = "3000-01-01"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

Plan: 0 to add, 3 to change, 0 to destroy.

@hmcts-platform-operations
Copy link

Plan Result (Aks_test)

Plan: 0 to add, 8 to change, 0 to destroy.
  • Update
    • module.kubernetes["00"].azurerm_kubernetes_cluster.kubernetes_cluster
    • module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["cronjob"]
    • module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["linux"]
    • module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["msnode"]
    • module.kubernetes["01"].azurerm_kubernetes_cluster.kubernetes_cluster
    • module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["cronjob"]
    • module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["linux"]
    • module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["msnode"]
Change Result (Click me) 
  # module.kubernetes["00"].azurerm_kubernetes_cluster.kubernetes_cluster will be updated in-place
  ~ resource "azurerm_kubernetes_cluster" "kubernetes_cluster" {
        id                                  = "/subscriptions/3eec5bde-7feb-4566-bfb6-805df6e10b90/resourceGroups/ss-test-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-test-00-aks"
      ~ kubernetes_version                  = "1.29.4" -> "1.29"
        name                                = "ss-test-00-aks"
        tags                                = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Medium"
            "environment"  = "testing"
        }
        # (35 unchanged attributes hidden)

      ~ default_node_pool {
            name                          = "system"
          ~ orchestrator_version          = "1.29.4" -> "1.29"
            tags                          = {
                "application"  = "core"
                "autoShutdown" = "true"
                "builtFrom"    = "hmcts/aks-sds-deploy"
                "businessArea" = "Cross-Cutting"
                "criticality"  = "Medium"
                "environment"  = "testing"
            }
            # (31 unchanged attributes hidden)

            # (1 unchanged block hidden)
        }

        # (9 unchanged blocks hidden)
    }

  # module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["cronjob"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/3eec5bde-7feb-4566-bfb6-805df6e10b90/resourceGroups/ss-test-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-test-00-aks/agentPools/cronjob"
        name                          = "cronjob"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Medium"
            "environment"  = "testing"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["linux"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/3eec5bde-7feb-4566-bfb6-805df6e10b90/resourceGroups/ss-test-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-test-00-aks/agentPools/linux"
        name                          = "linux"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Medium"
            "environment"  = "testing"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["msnode"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/3eec5bde-7feb-4566-bfb6-805df6e10b90/resourceGroups/ss-test-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-test-00-aks/agentPools/msnode"
        name                          = "msnode"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Medium"
            "environment"  = "testing"
        }
        # (32 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

  # module.kubernetes["01"].azurerm_kubernetes_cluster.kubernetes_cluster will be updated in-place
  ~ resource "azurerm_kubernetes_cluster" "kubernetes_cluster" {
        id                                  = "/subscriptions/3eec5bde-7feb-4566-bfb6-805df6e10b90/resourceGroups/ss-test-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-test-01-aks"
      ~ kubernetes_version                  = "1.29.4" -> "1.29"
        name                                = "ss-test-01-aks"
        tags                                = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Medium"
            "environment"  = "testing"
        }
        # (35 unchanged attributes hidden)

      ~ default_node_pool {
            name                          = "system"
          ~ orchestrator_version          = "1.29.4" -> "1.29"
            tags                          = {
                "application"  = "core"
                "autoShutdown" = "true"
                "builtFrom"    = "hmcts/aks-sds-deploy"
                "businessArea" = "Cross-Cutting"
                "criticality"  = "Medium"
                "environment"  = "testing"
            }
            # (31 unchanged attributes hidden)

            # (1 unchanged block hidden)
        }

        # (9 unchanged blocks hidden)
    }

  # module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["cronjob"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/3eec5bde-7feb-4566-bfb6-805df6e10b90/resourceGroups/ss-test-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-test-01-aks/agentPools/cronjob"
        name                          = "cronjob"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Medium"
            "environment"  = "testing"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["linux"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/3eec5bde-7feb-4566-bfb6-805df6e10b90/resourceGroups/ss-test-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-test-01-aks/agentPools/linux"
        name                          = "linux"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Medium"
            "environment"  = "testing"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["msnode"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/3eec5bde-7feb-4566-bfb6-805df6e10b90/resourceGroups/ss-test-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-test-01-aks/agentPools/msnode"
        name                          = "msnode"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Medium"
            "environment"  = "testing"
        }
        # (32 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 8 to change, 0 to destroy.

@hmcts-platform-operations
Copy link

Plan Result (Aks_ithc)

Plan: 0 to add, 4 to change, 0 to destroy.
  • Update
    • module.kubernetes["00"].azurerm_kubernetes_cluster.kubernetes_cluster
    • module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["cronjob"]
    • module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["linux"]
    • module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["msnode"]
Change Result (Click me) 
  # module.kubernetes["00"].azurerm_kubernetes_cluster.kubernetes_cluster will be updated in-place
  ~ resource "azurerm_kubernetes_cluster" "kubernetes_cluster" {
        id                                  = "/subscriptions/ba71a911-e0d6-4776-a1a6-079af1df7139/resourceGroups/ss-ithc-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-ithc-00-aks"
      ~ kubernetes_version                  = "1.29.4" -> "1.29"
        name                                = "ss-ithc-00-aks"
        tags                                = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Medium"
            "environment"  = "ithc"
        }
        # (35 unchanged attributes hidden)

      ~ default_node_pool {
            name                          = "system"
          ~ orchestrator_version          = "1.29.4" -> "1.29"
            tags                          = {
                "application"  = "core"
                "autoShutdown" = "true"
                "builtFrom"    = "hmcts/aks-sds-deploy"
                "businessArea" = "Cross-Cutting"
                "criticality"  = "Medium"
                "environment"  = "ithc"
            }
            # (31 unchanged attributes hidden)

            # (1 unchanged block hidden)
        }

        # (8 unchanged blocks hidden)
    }

  # module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["cronjob"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/ba71a911-e0d6-4776-a1a6-079af1df7139/resourceGroups/ss-ithc-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-ithc-00-aks/agentPools/cronjob"
        name                          = "cronjob"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Medium"
            "environment"  = "ithc"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["linux"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/ba71a911-e0d6-4776-a1a6-079af1df7139/resourceGroups/ss-ithc-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-ithc-00-aks/agentPools/linux"
        name                          = "linux"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Medium"
            "environment"  = "ithc"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["msnode"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/ba71a911-e0d6-4776-a1a6-079af1df7139/resourceGroups/ss-ithc-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-ithc-00-aks/agentPools/msnode"
        name                          = "msnode"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Medium"
            "environment"  = "ithc"
        }
        # (32 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 4 to change, 0 to destroy.

@hmcts-platform-operations
Copy link

Plan Result (Aks_demo)

Plan: 0 to add, 8 to change, 0 to destroy.
  • Update
    • module.kubernetes["00"].azurerm_kubernetes_cluster.kubernetes_cluster
    • module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["cronjob"]
    • module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["linux"]
    • module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["msnode"]
    • module.kubernetes["01"].azurerm_kubernetes_cluster.kubernetes_cluster
    • module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["cronjob"]
    • module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["linux"]
    • module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["msnode"]
Change Result (Click me) 
  # module.kubernetes["00"].azurerm_kubernetes_cluster.kubernetes_cluster will be updated in-place
  ~ resource "azurerm_kubernetes_cluster" "kubernetes_cluster" {
        id                                  = "/subscriptions/c68a4bed-4c3d-4956-af51-4ae164c1957c/resourceGroups/ss-demo-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-demo-00-aks"
      ~ kubernetes_version                  = "1.29.4" -> "1.29"
        name                                = "ss-demo-00-aks"
        tags                                = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Medium"
            "environment"  = "demo"
        }
        # (35 unchanged attributes hidden)

      ~ default_node_pool {
            name                          = "system"
          ~ orchestrator_version          = "1.29.4" -> "1.29"
            tags                          = {
                "application"  = "core"
                "autoShutdown" = "true"
                "builtFrom"    = "hmcts/aks-sds-deploy"
                "businessArea" = "Cross-Cutting"
                "criticality"  = "Medium"
                "environment"  = "demo"
            }
            # (31 unchanged attributes hidden)

            # (1 unchanged block hidden)
        }

        # (8 unchanged blocks hidden)
    }

  # module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["cronjob"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/c68a4bed-4c3d-4956-af51-4ae164c1957c/resourceGroups/ss-demo-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-demo-00-aks/agentPools/cronjob"
        name                          = "cronjob"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Medium"
            "environment"  = "demo"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["linux"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/c68a4bed-4c3d-4956-af51-4ae164c1957c/resourceGroups/ss-demo-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-demo-00-aks/agentPools/linux"
        name                          = "linux"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Medium"
            "environment"  = "demo"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["00"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["msnode"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/c68a4bed-4c3d-4956-af51-4ae164c1957c/resourceGroups/ss-demo-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-demo-00-aks/agentPools/msnode"
        name                          = "msnode"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Medium"
            "environment"  = "demo"
        }
        # (32 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

  # module.kubernetes["01"].azurerm_kubernetes_cluster.kubernetes_cluster will be updated in-place
  ~ resource "azurerm_kubernetes_cluster" "kubernetes_cluster" {
        id                                  = "/subscriptions/c68a4bed-4c3d-4956-af51-4ae164c1957c/resourceGroups/ss-demo-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-demo-01-aks"
      ~ kubernetes_version                  = "1.29.4" -> "1.29"
        name                                = "ss-demo-01-aks"
        tags                                = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Medium"
            "environment"  = "demo"
        }
        # (35 unchanged attributes hidden)

      ~ default_node_pool {
            name                          = "system"
          ~ orchestrator_version          = "1.29.4" -> "1.29"
            tags                          = {
                "application"  = "core"
                "autoShutdown" = "true"
                "builtFrom"    = "hmcts/aks-sds-deploy"
                "businessArea" = "Cross-Cutting"
                "criticality"  = "Medium"
                "environment"  = "demo"
            }
            # (31 unchanged attributes hidden)

            # (1 unchanged block hidden)
        }

        # (8 unchanged blocks hidden)
    }

  # module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["cronjob"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/c68a4bed-4c3d-4956-af51-4ae164c1957c/resourceGroups/ss-demo-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-demo-01-aks/agentPools/cronjob"
        name                          = "cronjob"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Medium"
            "environment"  = "demo"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["linux"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/c68a4bed-4c3d-4956-af51-4ae164c1957c/resourceGroups/ss-demo-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-demo-01-aks/agentPools/linux"
        name                          = "linux"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Medium"
            "environment"  = "demo"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["msnode"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/c68a4bed-4c3d-4956-af51-4ae164c1957c/resourceGroups/ss-demo-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-demo-01-aks/agentPools/msnode"
        name                          = "msnode"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Medium"
            "environment"  = "demo"
        }
        # (32 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 8 to change, 0 to destroy.

@hmcts-platform-operations
Copy link

Plan Result (Aks_dev)

Plan: 0 to add, 4 to change, 0 to destroy.
  • Update
    • module.kubernetes["01"].azurerm_kubernetes_cluster.kubernetes_cluster
    • module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["cronjob"]
    • module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["linux"]
    • module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["msnode"]
Change Result (Click me) 
  # module.kubernetes["01"].azurerm_kubernetes_cluster.kubernetes_cluster will be updated in-place
  ~ resource "azurerm_kubernetes_cluster" "kubernetes_cluster" {
        id                                  = "/subscriptions/867a878b-cb68-4de5-9741-361ac9e178b6/resourceGroups/ss-dev-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-dev-01-aks"
      ~ kubernetes_version                  = "1.29.4" -> "1.29"
        name                                = "ss-dev-01-aks"
        tags                                = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Low"
            "environment"  = "development"
        }
        # (35 unchanged attributes hidden)

      ~ default_node_pool {
            name                          = "system"
          ~ orchestrator_version          = "1.29.4" -> "1.29"
            tags                          = {
                "application"  = "core"
                "autoShutdown" = "true"
                "builtFrom"    = "hmcts/aks-sds-deploy"
                "businessArea" = "Cross-Cutting"
                "criticality"  = "Low"
                "environment"  = "development"
            }
            # (31 unchanged attributes hidden)

            # (1 unchanged block hidden)
        }

        # (8 unchanged blocks hidden)
    }

  # module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["cronjob"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/867a878b-cb68-4de5-9741-361ac9e178b6/resourceGroups/ss-dev-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-dev-01-aks/agentPools/cronjob"
        name                          = "cronjob"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Low"
            "environment"  = "development"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["linux"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/867a878b-cb68-4de5-9741-361ac9e178b6/resourceGroups/ss-dev-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-dev-01-aks/agentPools/linux"
        name                          = "linux"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Low"
            "environment"  = "development"
        }
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.kubernetes["01"].azurerm_kubernetes_cluster_node_pool.additional_node_pools["msnode"] will be updated in-place
  ~ resource "azurerm_kubernetes_cluster_node_pool" "additional_node_pools" {
        id                            = "/subscriptions/867a878b-cb68-4de5-9741-361ac9e178b6/resourceGroups/ss-dev-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-dev-01-aks/agentPools/msnode"
        name                          = "msnode"
      ~ orchestrator_version          = "1.29.4" -> "1.29"
        tags                          = {
            "application"  = "core"
            "autoShutdown" = "true"
            "builtFrom"    = "hmcts/aks-sds-deploy"
            "businessArea" = "Cross-Cutting"
            "criticality"  = "Low"
            "environment"  = "development"
        }
        # (32 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 4 to change, 0 to destroy.

@hmcts-platform-operations
Copy link

Plan Result (Genesis_prod)

No changes. Your infrastructure matches the configuration.

@hmcts-platform-operations
Copy link

Plan Result (Genesis_ptl)

No changes. Your infrastructure matches the configuration.

@hmcts-platform-operations
Copy link

Plan Result (Network_ptl)

No changes. Your infrastructure matches the configuration.

@hmcts-platform-operations
Copy link

Plan Result (Network_prod)

No changes. Your infrastructure matches the configuration.

@hmcts-platform-operations
Copy link

Plan Result (Managed_Identity_ptl)

Plan: 0 to add, 1 to change, 0 to destroy.
  • Update
    • azurerm_resource_group.application-mi
Change Result (Click me) 
  # azurerm_resource_group.application-mi will be updated in-place
  ~ resource "azurerm_resource_group" "application-mi" {
        id         = "/subscriptions/6c4d2513-a873-41b4-afdd-b05a33206631/resourceGroups/managed-identities-ptl-rg"
        name       = "managed-identities-ptl-rg"
      ~ tags       = {
          + "application"  = "core"
          + "builtFrom"    = "hmcts/aks-sds-deploy"
          + "businessArea" = "Cross-Cutting"
          + "criticality"  = "High"
          + "environment"  = "production"
          + "startupMode"  = "always"
        }
        # (2 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

@hmcts-platform-operations
Copy link

Plan Result (Managed_Identity_prod)

Plan: 0 to add, 1 to change, 0 to destroy.
  • Update
    • azurerm_resource_group.application-mi
Change Result (Click me) 
  # azurerm_resource_group.application-mi will be updated in-place
  ~ resource "azurerm_resource_group" "application-mi" {
        id         = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/managed-identities-prod-rg"
        name       = "managed-identities-prod-rg"
      ~ tags       = {
          + "application"  = "core"
          + "builtFrom"    = "hmcts/aks-sds-deploy"
          + "businessArea" = "Cross-Cutting"
          + "criticality"  = "High"
          + "environment"  = "production"
          + "startupMode"  = "always"
        }
        # (2 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

@hmcts-platform-operations
Copy link

Plan Result (Aks_ptl)

No changes. Your infrastructure matches the configuration.

@hmcts-platform-operations
Copy link

Plan Result (Aks_prod)

Plan: 0 to add, 4 to change, 0 to destroy.
  • Update
    • module.kubernetes["00"].azurerm_monitor_diagnostic_setting.kubernetes_cluster_diagnostic_setting[0]
    • module.kubernetes["00"].azurerm_monitor_diagnostic_setting.kubernetes_cluster_diagnostic_setting_sa[0]
    • module.kubernetes["01"].azurerm_monitor_diagnostic_setting.kubernetes_cluster_diagnostic_setting[0]
    • module.kubernetes["01"].azurerm_monitor_diagnostic_setting.kubernetes_cluster_diagnostic_setting_sa[0]
Change Result (Click me) 
  # module.kubernetes["00"].azurerm_monitor_diagnostic_setting.kubernetes_cluster_diagnostic_setting[0] will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "kubernetes_cluster_diagnostic_setting" {
        id                             = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/ss-prod-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-prod-00-aks|DiagLogAnalytics"
        name                           = "DiagLogAnalytics"
        # (5 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (16 unchanged blocks hidden)
    }

  # module.kubernetes["00"].azurerm_monitor_diagnostic_setting.kubernetes_cluster_diagnostic_setting_sa[0] will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "kubernetes_cluster_diagnostic_setting_sa" {
        id                             = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/ss-prod-00-rg/providers/Microsoft.ContainerService/managedClusters/ss-prod-00-aks|aks-storage"
        name                           = "aks-storage"
        # (6 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (12 unchanged blocks hidden)
    }

  # module.kubernetes["01"].azurerm_monitor_diagnostic_setting.kubernetes_cluster_diagnostic_setting[0] will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "kubernetes_cluster_diagnostic_setting" {
        id                             = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/ss-prod-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-prod-01-aks|DiagLogAnalytics"
        name                           = "DiagLogAnalytics"
        # (5 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (16 unchanged blocks hidden)
    }

  # module.kubernetes["01"].azurerm_monitor_diagnostic_setting.kubernetes_cluster_diagnostic_setting_sa[0] will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "kubernetes_cluster_diagnostic_setting_sa" {
        id                             = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/ss-prod-01-rg/providers/Microsoft.ContainerService/managedClusters/ss-prod-01-aks|aks-storage"
        name                           = "aks-storage"
        # (6 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (12 unchanged blocks hidden)
    }

Plan: 0 to add, 4 to change, 0 to destroy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madjava madjava madjava approved these changes

@endakelly endakelly Awaiting requested review from endakelly endakelly is a code owner automatically assigned from hmcts/platform-operations

@danielwilsonkainos danielwilsonkainos Awaiting requested review from danielwilsonkainos danielwilsonkainos is a code owner automatically assigned from hmcts/platform-operations

Assignees
No one assigned
Labels
Aks_demo/add-or-update Aks_dev/add-or-update Aks_ithc/add-or-update Aks_prod/add-or-update Aks_ptl/no-changes Aks_ptlsbox/add-or-update Aks_sbox/add-or-update Aks_stg/add-or-update Aks_test/add-or-update Genesis_demo/no-changes Genesis_dev/no-changes Genesis_ithc/no-changes Genesis_prod/no-changes Genesis_ptl/no-changes Genesis_ptlsbox/no-changes Genesis_sbox/no-changes Genesis_stg/no-changes Genesis_test/no-changes Managed_Identity_demo/add-or-update Managed_Identity_dev/no-changes Managed_Identity_ithc/add-or-update Managed_Identity_prod/add-or-update Managed_Identity_ptl/add-or-update Managed_Identity_ptlsbox/add-or-update Managed_Identity_sbox/add-or-update Managed_Identity_stg/add-or-update Managed_Identity_test/add-or-update Network_demo/no-changes Network_dev/no-changes Network_ithc/no-changes Network_prod/no-changes Network_ptl/no-changes Network_ptlsbox/no-changes Network_sbox/no-changes Network_stg/no-changes Network_test/no-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomast1906 @hmcts-platform-operations @madjava