Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/StackExchange/dnscontrol/v4 from 4.7.0 to 4.7.2 #57

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 5, 2023

Bumps github.com/StackExchange/dnscontrol/v4 from 4.7.0 to 4.7.2.

Release notes

Sourced from github.com/StackExchange/dnscontrol/v4's releases.

v4.7.2

Welcome to v4.7.2!

This is the first production-ready release in the v4.7.x series (v4.7.0 and v4.7.1-beta should not be used in production; sorry about any confusion that may have caused... this was the first time doing a release that way).

This release implements a single change: How TXT records are stored internally. There should be no user-visible changes.

  • TXT-handling code is now simplified with fewer edge-cases
  • A new opinion is added ("Opinion # 8 TXT Records are one long string")
  • The get-zone subcommand now generates TAB-separated files that are more correct for TXT records (the quotes were a bug).

TXT record handling was complex because we abstracted them at the wrong layer. Code that works with TXT records is now more simple, easier to modify, and a lot of minor bugs have been squashed. For example, diff'ing old and new TXT records is consistent across all providers.

Thanks to everyone for help testing this release!

Changelog

Other changes and improvements:

  • cbccbbeb8d981bcd688de1ee6ef8efe8df8a56d9: REFACTOR: Opinion: TXT records are one long string (#2631) (@​tlimoncelli)

v4.7.1-beta

THIS IS A PRE-RELEASE. DO NOT USE IN PRODUCTION. PLEASE DO TEST AND GIVE FEEDBACK ON PR StackExchange/dnscontrol#2631

The only change in this release is that TXT records are stored a new way. Instead of storing the individual segments, they are stored as one big string. The providers are now responsible for any joining, splitting, escaping, or quoting. There should be no user-visible effects.

NOTE TO MAINTAINERS OF PROVIDERS: Please test your provider. A lot changed in how TXT records are handled. Please re-run the integration tests like:

export PROVIDER_FOO=foo    # Set your ENV variables.  See providers.json for the list.
cd integrationTest/
go test -v -verbose -provider NAME_OF_PROVIDER
# This next line just runs the TXT tests.
go test -v -verbose -provider NAME_OF_PROVIDER -start 16 -end 17

Fix any broken tests. Post a comment if you need help or to let me know the test results.

The branch is tlim_newtxt_minimal.

PR is StackExchange/dnscontrol#2631

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/StackExchange/dnscontrol/v4](https://github.com/StackExchange/dnscontrol) from 4.7.0 to 4.7.2.
- [Release notes](https://github.com/StackExchange/dnscontrol/releases)
- [Changelog](https://github.com/StackExchange/dnscontrol/blob/master/documentation/release-engineering.md)
- [Commits](StackExchange/dnscontrol@v4.7.0...v4.7.2)

---
updated-dependencies:
- dependency-name: github.com/StackExchange/dnscontrol/v4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Dec 5, 2023
@fritterhoff fritterhoff added this pull request to the merge queue Dec 6, 2023
Merged via the queue into main with commit 123d7d8 Dec 6, 2023
1 check passed
@fritterhoff fritterhoff deleted the dependabot/go_modules/github.com/StackExchange/dnscontrol/v4-4.7.2 branch December 6, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant