Update identifier indices for inline examples #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUSHI currently resolves soft indexing in a way that does not account for existing named slices. As a result, the identifier slices on these examples were having the values in the "mpid" slice overwritten. This update sets the indices such that there are two elements in the identifier arrays. The manual slice ordering feature that will be part of SUSHI v3.0 will allow soft indexing to be used here, if the feature is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing a planned feature for SUSHI v3.0, I discovered a potential discrepancy involving the use of soft indexing in two examples. If my understanding of the intent of these examples is correct, the
identifierarrays should have two elements in them: the namedmpidslice, followed by an element without a slice name.SUSHI currently resolves soft indexing in a way that does not account for existing named slices. As a result, the identifier slices on these examples were having the values in the
mpidslice overwritten. This update sets the indices such that there are two elements in the identifier arrays. The manual slice ordering feature that will be part of SUSHI v3.0 will allow soft indexing to be used here, if the feature is enabled.