Merge pull request seahorce-scidac#133 from hklion/check_bc_type

Check BC type is outflow when init from netcdf

Exec/OCCAMS/inputs

@@ -12,10 +12,15 @@ geometry.prob_hi     =   320000.  320000.       0.
 
 amr.n_cell           =  563 751 40
 
-geometry.is_periodic = 1 1 0
+geometry.is_periodic = 0 0 0
 zlo.type = "SlipWall"
 zhi.type = "SlipWall"
 
+xlo.type = "outflow"
+xhi.type = "outflow"
+ylo.type = "outflow"
+yhi.type = "outflow"
+
 # TIME STEP CONTROL
 remora.fixed_dt            = 60.0 # Timestep size (seconds)
 remora.fixed_ndtfast_ratio = 20 # Baratropic timestep size (seconds)

Source/Initialization/REMORA_init_bcs.cpp

@@ -92,6 +92,14 @@ void REMORA::init_bcs ()
              amrex::Print() << "BC Type specified for face " << bcid << " is " << bc_type_in << std::endl;
              amrex::Abort("This BC type is unknown");
         }
+
+        if ((bcid == "xlo" || bcid == "xhi" ||
+             bcid == "ylo" || bcid == "yhi") &&
+            solverChoice.ic_bc_type == IC_BC_Type::Real &&
+            phys_bc_type[ori] != REMORA_BC::outflow)
+        {
+            amrex::Abort("BC type must be outflow in x and y when reading BCs from file");
+        }
     };
 
     f("xlo", Orientation(Direction::x,Orientation::low));