Use spaceship everywhere. (eBay#69)

hkadayam · Sep 27, 2023 · d487afd · d487afd
1 parent 34abfd7
commit d487afd
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 6 deletions.
diff --git a/src/include/homeobject/pg_manager.hpp b/src/include/homeobject/pg_manager.hpp
@@ -1,4 +1,5 @@
 #pragma once
+#include <compare>
 #include <set>
 #include <string>
 
@@ -17,6 +18,11 @@ struct PGMember {
     peer_id_t id;
     std::string name;
     int32_t priority{0}; // <0 (Arbiter), ==0 (Follower), >0 (F|Leader)
+
+    auto operator<=>(PGMember const& rhs) const {
+        return boost::uuids::hash_value(id) <=> boost::uuids::hash_value(rhs.id);
+    }
+    auto operator==(PGMember const& rhs) const { return id == rhs.id; }
 };
 
 using MemberSet = std::set< PGMember >;
@@ -26,6 +32,9 @@ struct PGInfo {
     pg_id_t id;
     mutable MemberSet members;
     peer_id_t replica_set_uuid;
+
+    auto operator<=>(PGInfo const& rhs) const { return id <=> rhs.id; }
+    auto operator==(PGInfo const& rhs) const { return id == rhs.id; }
 };
 
 class PGManager : public Manager< PGError > {
@@ -34,7 +43,4 @@ class PGManager : public Manager< PGError > {
     virtual NullAsyncResult replace_member(pg_id_t id, peer_id_t const& old_member, PGMember const& new_member) = 0;
 };
 
-inline bool operator<(homeobject::PGMember const& lhs, homeobject::PGMember const& rhs) { return lhs.id < rhs.id; }
-inline bool operator<(homeobject::PGInfo const& lhs, homeobject::PGInfo const& rhs) { return lhs.id < rhs.id; }
-
 } // namespace homeobject
diff --git a/src/include/homeobject/shard_manager.hpp b/src/include/homeobject/shard_manager.hpp
@@ -1,4 +1,5 @@
 #pragma once
+#include <compare>
 #include <list>
 #include <optional>
 
@@ -26,6 +27,9 @@ struct ShardInfo {
     uint64_t total_capacity_bytes;
     uint64_t deleted_capacity_bytes;
     std::optional< peer_id_t > current_leader{std::nullopt};
+
+    auto operator<=>(ShardInfo const& rhs) const { return id <=> rhs.id; }
+    auto operator==(ShardInfo const& rhs) const { return id == rhs.id; }
 };
 
 using InfoList = std::list< ShardInfo >;

diff --git a/src/lib/blob_route.hpp b/src/lib/blob_route.hpp
@@ -1,3 +1,4 @@
+#include <compare>
 #include <functional>
 
 #include <boost/functional/hash.hpp>

diff --git a/src/lib/homeobject_impl.hpp b/src/lib/homeobject_impl.hpp
@@ -21,9 +21,6 @@ inline shard_id_t make_new_shard_id(pg_id_t pg, shard_id_t next_shard) {
     return ((uint64_t)pg << shard_width) | next_shard;
 }
 
-inline bool operator<(ShardInfo const& lhs, ShardInfo const& rhs) { return lhs.id < rhs.id; }
-inline bool operator==(ShardInfo const& lhs, ShardInfo const& rhs) { return lhs.id == rhs.id; }
-
 struct Shard {
     explicit Shard(ShardInfo info) : info(std::move(info)) {}
     ShardInfo info;