Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review chapter 22 #341

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions chapter_22_fixtures_and_wait_decorator.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,7 @@ def wait(fn): #<1>
return modified_fn #<2>
----
====
// JAN: Why not use functools.wraps here?

<1> A decorator is a way of modifying a function;
it takes a function as an [keep-together]#argument...#
Expand Down Expand Up @@ -503,6 +504,7 @@ $ pass:quotes[*python src/manage.py test functional_tests.test_my_lists*]
OK
----

// JAN: This command runs no tests foe me - Ran 0 tests in 0.000s

And do you know what's truly satisfying?
We can use our `wait` decorator for our `self.wait_for` helper as well!
Expand Down
Loading