Set scheduler_specific_kwargs to get_scheduler #4006
Merged
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When setting the argument
--lr_scheduler_type cosine_with_min_lr
forpython src/train.py
, the following error occurs:In response, I provided the argument
--lr_scheduler_kwargs '{"min_lr": 1e-7}'
, but an error still occurs because thescheduler_specific_kwargs
argument is not properly passed to theget_scheduler
function within thecreate_custom_scheduler
function insrc/llamafactory/train/utils.py
.To resolve this error, I have modified the code to set the
scheduler_specific_kwargs
argument totraining_args.lr_scheduler_kwargs
within thecreate_custom_scheduler
function.Before submitting