-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for using block_api.get_block API #61
Conversation
d556f33
to
b904ff6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you've changed the enableHashVerification setting to hashVerificationNode, but forgot to make the corresponding update to config.example.json.
Also, can you please document on the PR what each of the new streamerConfig settings is for, and confirm that the default values you've selected are good values for production use (so node operators can simply copy the example when upgrading)?
Done with config. Updating PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good now.
Prepares for eventual deprecation of condenser_api.get_block.
Moves a few configurable options to config:
"https://api.hive-engine.com/rpc/blockchain"
Also