Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pbs 271 new root group #279

Merged
merged 5 commits into from
Oct 20, 2023

Conversation

TheWalkingLeek
Copy link
Member

@TheWalkingLeek TheWalkingLeek commented May 23, 2023

Closes: #271
Requires: hitobito/hitobito#2111
DO NOT MERGE YET
We'll wait until everything regarding SiSc is ready or actively being worked on. Otherwise we will be blocking releases

Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beim Refinement wurde vergessen, dass die Silverscouts in Regionen unterteilt sind. Spezifikation im Ticket wurde überarbeitet, in diesem PR muss jetzt nochmals nachgebessert werden.

@TheWalkingLeek TheWalkingLeek force-pushed the feature/pbs_271_new_root_group branch from 6c49d1b to aab45e5 Compare September 11, 2023 06:24
@daniel-illi daniel-illi self-requested a review September 11, 2023 15:35
Copy link
Contributor

@daniel-illi daniel-illi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@daniel-illi
Copy link
Contributor

Die specs schlagen noch fehl.

@daniel-illi daniel-illi force-pushed the feature/pbs_271_new_root_group branch from f213943 to 7fd1ade Compare October 20, 2023 09:52
@daniel-illi daniel-illi changed the base branch from master to feature/silverscouts October 20, 2023 09:53
@daniel-illi daniel-illi merged commit c8fbbbb into feature/silverscouts Oct 20, 2023
1 of 3 checks passed
@daniel-illi daniel-illi deleted the feature/pbs_271_new_root_group branch October 20, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silverscouts: Eigener Root-Knoten
3 participants