-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
* Switch from setup.py to pyproject.toml #68
Changes from 2 commits
e65c729
4a2f873
4b4f379
b1f8f7f
fb20090
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
[build-system] | ||
requires = ["setuptools"] | ||
build-backend = "setuptools.build_meta" | ||
|
||
[project] | ||
name = "histogrammar" | ||
description = "Composable histogram primitives for distributed data reduction" | ||
keywords = [ | ||
"pandas", | ||
"spark", | ||
"data-science", | ||
"data-analysis", | ||
"statistics", | ||
"python", | ||
"jupyter", | ||
"ipython" | ||
] | ||
readme = "README.rst" | ||
requires-python = ">=3.9" | ||
authors = [{ name = "Jim Pivarski (DIANA-HEP)", email = "[email protected]" }, { name = "Max Baak", email = "[email protected]" }] | ||
maintainers = [{ name = "Max Baak", email = "[email protected]" }] | ||
license = { type = "Apache Software License v2", file = "LICENSE" } | ||
dependencies = [ | ||
"numpy", | ||
"tqdm", | ||
"joblib>=0.14.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see that joblib is no longer used. Can you remove it? |
||
] | ||
classifiers = ["Development Status :: 5 - Production/Stable", | ||
"Environment :: Console", | ||
"Intended Audience :: Science/Research", | ||
"License :: OSI Approved :: Apache Software License", | ||
"Topic :: Scientific/Engineering :: Information Analysis", | ||
"Topic :: Scientific/Engineering :: Mathematics", | ||
"Topic :: Scientific/Engineering :: Physics", | ||
] | ||
dynamic = ["version"] | ||
|
||
[project.optional-dependencies] | ||
test = [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add the optional dependencies: spark = [ There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
"ipykernel>=5.1.3", | ||
"jupyter_client>=5.2.3", | ||
"matplotlib", | ||
"pandas", | ||
"pre-commit>=2.9.0", | ||
"pytest-notebook>=0.6.1", | ||
"pytest>=4.0.2", | ||
] | ||
test_numpy_pre2 = [ | ||
"numpy<2", | ||
"pandas<2", | ||
] | ||
|
||
# files to be shipped with the installation, under: histogrammar/test_data and histogrammar/notebooks | ||
# after installation, these can be found with the functions in resources.py | ||
[tool.setuptools.package-data] | ||
histogrammar = [ | ||
"test_data/*.csv.gz", | ||
"test_data/*.json*", | ||
"notebooks/*tutorial*.ipynb", | ||
] | ||
|
||
[project.urls] | ||
repository = "https://github.com/histogrammar/histogrammar-python" | ||
|
||
[tool.semantic_release] | ||
version_variable = [ | ||
"histogrammar/version.py:version", | ||
] | ||
build_command = "pip install build && python -m build" | ||
|
||
[tool.setuptools.dynamic] | ||
version = { attr = "histogrammar.version.version" } |
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you switch
[test]
->[test,spark]
?(See also pyproject.toml below).
I think that will trigger the spark tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added, seems it works :)
However, should we also add "spark" to "numpy<2" test?
pip install ".[test,spark,test_numpy_pre2]"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Yes, let's run them there as well.
(Happy to merge when that runs.)