fix: demote server connection errors and contract clarity errors to be non-retryable #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel deployment URL: https://token-metadata-9keos6fr7-hirosystems.vercel.app 🚀 |
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
blockstack-devops
pushed a commit
that referenced
this pull request
Aug 27, 2024
## [1.0.1](v1.0.0...v1.0.1) (2024-08-27) ### Bug Fixes * demote server connection errors and contract clarity errors to be non-retryable ([#249](#249)) ([87ad8af](87ad8af))
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the errors we were considering as retryable were not really retryable. For example, if a metadata server produced an
ECONNRESETerror, most of the time it was an error that happened consistently even when retrying after a while. Since we're running in strict mode, this caused an inifite retry of these jobs which makes no sense.Because of this, this PR only leaves temporary Stacks node errors and 429 rate limit errors to be infinitely retryable because they are (almost) guaranteed to be resolved after a number of retries.