Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Update Cl.serialize to return string instead of bytes #1753

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Oct 23, 2024

This PR was published to npm with the version 6.14.1-pr.89+5155caff
e.g. npm install @stacks/[email protected]+5155caff --save-exact

  • Update Cl.serialize to return string instead of bytes

@janniks janniks requested a review from hugocaillard October 23, 2024 20:34
Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 7:06pm

@janniks janniks force-pushed the 10-23-refactor_update_cl.serialize_to_return_string_instead_of_bytes branch from aa69c1c to 6dc2811 Compare October 23, 2024 20:38
@janniks janniks force-pushed the 10-23-refactor_update_cl.serialize_to_return_string_instead_of_bytes branch from 6dc2811 to 37e5c4f Compare October 23, 2024 20:41
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@janniks janniks force-pushed the 10-23-refactor_update_cl.serialize_to_return_string_instead_of_bytes branch from 37e5c4f to baa1a27 Compare October 24, 2024 15:12
@janniks janniks force-pushed the 10-23-refactor_change_getstxaddress_to_use_network_parameter branch from 912069b to 37e7c31 Compare October 24, 2024 15:12
@janniks janniks force-pushed the 10-23-refactor_change_getstxaddress_to_use_network_parameter branch from 37e7c31 to 9b9cd4f Compare October 25, 2024 12:05
@janniks janniks force-pushed the 10-23-refactor_update_cl.serialize_to_return_string_instead_of_bytes branch from baa1a27 to 5155caf Compare October 25, 2024 12:05
Copy link
Contributor

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@janniks janniks force-pushed the 10-23-refactor_change_getstxaddress_to_use_network_parameter branch from 9b9cd4f to 91423d8 Compare October 25, 2024 18:55
@janniks janniks force-pushed the 10-23-refactor_update_cl.serialize_to_return_string_instead_of_bytes branch from 5155caf to 3c2d3c8 Compare October 25, 2024 18:55
@janniks janniks force-pushed the 10-23-refactor_change_getstxaddress_to_use_network_parameter branch from 91423d8 to f22c9a6 Compare October 25, 2024 18:55
@janniks janniks force-pushed the 10-23-refactor_update_cl.serialize_to_return_string_instead_of_bytes branch from 3c2d3c8 to 3f02819 Compare October 25, 2024 18:55
@janniks janniks force-pushed the 10-23-refactor_change_getstxaddress_to_use_network_parameter branch from f22c9a6 to 8dda5fc Compare October 25, 2024 18:55
@janniks janniks force-pushed the 10-23-refactor_update_cl.serialize_to_return_string_instead_of_bytes branch from 3f02819 to d28ae0c Compare October 25, 2024 18:55
@janniks janniks force-pushed the 10-23-refactor_change_getstxaddress_to_use_network_parameter branch from 8dda5fc to f58788b Compare October 25, 2024 18:56
@janniks janniks force-pushed the 10-23-refactor_update_cl.serialize_to_return_string_instead_of_bytes branch 2 times, most recently from 3db1da5 to 892cab4 Compare October 25, 2024 18:57
@janniks janniks force-pushed the 10-23-refactor_change_getstxaddress_to_use_network_parameter branch from f58788b to 3bb149d Compare October 25, 2024 18:57
Base automatically changed from 10-23-refactor_change_getstxaddress_to_use_network_parameter to next October 25, 2024 18:57
@janniks janniks force-pushed the 10-23-refactor_update_cl.serialize_to_return_string_instead_of_bytes branch from 892cab4 to 6a29233 Compare October 25, 2024 18:57
@janniks janniks merged commit 3d4052b into next Oct 25, 2024
1 of 2 checks passed
@janniks janniks deleted the 10-23-refactor_update_cl.serialize_to_return_string_instead_of_bytes branch October 25, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants