-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Update Cl.serialize to return string instead of bytes #1753
Merged
janniks
merged 1 commit into
next
from
10-23-refactor_update_cl.serialize_to_return_string_instead_of_bytes
Oct 25, 2024
Merged
refactor!: Update Cl.serialize to return string instead of bytes #1753
janniks
merged 1 commit into
next
from
10-23-refactor_update_cl.serialize_to_return_string_instead_of_bytes
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
janniks
commented
Oct 23, 2024
•
edited by github-actions
bot
Loading
edited by github-actions
bot
- Update Cl.serialize to return string instead of bytes
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
janniks
force-pushed
the
10-23-refactor_update_cl.serialize_to_return_string_instead_of_bytes
branch
from
October 23, 2024 20:38
aa69c1c
to
6dc2811
Compare
janniks
force-pushed
the
10-23-refactor_update_cl.serialize_to_return_string_instead_of_bytes
branch
from
October 23, 2024 20:41
6dc2811
to
37e5c4f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
janniks
force-pushed
the
10-23-refactor_update_cl.serialize_to_return_string_instead_of_bytes
branch
from
October 24, 2024 15:12
37e5c4f
to
baa1a27
Compare
janniks
force-pushed
the
10-23-refactor_change_getstxaddress_to_use_network_parameter
branch
from
October 24, 2024 15:12
912069b
to
37e7c31
Compare
zone117x
approved these changes
Oct 25, 2024
janniks
force-pushed
the
10-23-refactor_change_getstxaddress_to_use_network_parameter
branch
from
October 25, 2024 12:05
37e7c31
to
9b9cd4f
Compare
janniks
force-pushed
the
10-23-refactor_update_cl.serialize_to_return_string_instead_of_bytes
branch
from
October 25, 2024 12:05
baa1a27
to
5155caf
Compare
hugocaillard
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
janniks
force-pushed
the
10-23-refactor_change_getstxaddress_to_use_network_parameter
branch
from
October 25, 2024 18:55
9b9cd4f
to
91423d8
Compare
janniks
force-pushed
the
10-23-refactor_update_cl.serialize_to_return_string_instead_of_bytes
branch
from
October 25, 2024 18:55
5155caf
to
3c2d3c8
Compare
janniks
force-pushed
the
10-23-refactor_change_getstxaddress_to_use_network_parameter
branch
from
October 25, 2024 18:55
91423d8
to
f22c9a6
Compare
janniks
force-pushed
the
10-23-refactor_update_cl.serialize_to_return_string_instead_of_bytes
branch
from
October 25, 2024 18:55
3c2d3c8
to
3f02819
Compare
janniks
force-pushed
the
10-23-refactor_change_getstxaddress_to_use_network_parameter
branch
from
October 25, 2024 18:55
f22c9a6
to
8dda5fc
Compare
janniks
force-pushed
the
10-23-refactor_update_cl.serialize_to_return_string_instead_of_bytes
branch
from
October 25, 2024 18:55
3f02819
to
d28ae0c
Compare
janniks
force-pushed
the
10-23-refactor_change_getstxaddress_to_use_network_parameter
branch
from
October 25, 2024 18:56
8dda5fc
to
f58788b
Compare
janniks
force-pushed
the
10-23-refactor_update_cl.serialize_to_return_string_instead_of_bytes
branch
2 times, most recently
from
October 25, 2024 18:57
3db1da5
to
892cab4
Compare
janniks
force-pushed
the
10-23-refactor_change_getstxaddress_to_use_network_parameter
branch
from
October 25, 2024 18:57
f58788b
to
3bb149d
Compare
Base automatically changed from
10-23-refactor_change_getstxaddress_to_use_network_parameter
to
next
October 25, 2024 18:57
janniks
force-pushed
the
10-23-refactor_update_cl.serialize_to_return_string_instead_of_bytes
branch
from
October 25, 2024 18:57
892cab4
to
6a29233
Compare
janniks
deleted the
10-23-refactor_update_cl.serialize_to_return_string_instead_of_bytes
branch
October 25, 2024 18:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.