Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add hiro headers #1549

Merged
merged 1 commit into from
Sep 18, 2023
Merged

fix: add hiro headers #1549

merged 1 commit into from
Sep 18, 2023

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Sep 18, 2023 •
edited by github-actions bot
Loading

This PR was published to npm with the version 6.8.1-pr.fe1a553.0
e.g. npm install @stacks/[email protected] --save-exact

@vercel
Copy link

vercel bot commented Sep 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 1:46pm

@janniks janniks force-pushed the feat/add-hiro-headers branch 3 times, most recently from 77755a4 to bfe996c Compare September 18, 2023 13:12
@janniks janniks changed the title feat: add hiro headers fix: add hiro headers Sep 18, 2023
@janniks janniks force-pushed the feat/add-hiro-headers branch from bfe996c to c14ea95 Compare September 18, 2023 13:14
@janniks janniks changed the base branch from next to main September 18, 2023 13:14
@janniks janniks force-pushed the feat/add-hiro-headers branch from c14ea95 to b7b01ae Compare September 18, 2023 13:21
@janniks janniks force-pushed the feat/add-hiro-headers branch from b7b01ae to fe1a553 Compare September 18, 2023 13:45
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #1549 (fe1a553) into main (debeb00) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1549   +/-   ##
=======================================
  Coverage   66.18%   66.18%           
=======================================
  Files         118      118           
  Lines        8640     8640           
  Branches     1908     1908           
=======================================
  Hits         5718     5718           
  Misses       2685     2685           
  Partials      237      237
Files Changed Coverage Δ
packages/network/src/fetch.ts 97.95% <100.00%> (ø)

sabbyanandan
sabbyanandan approved these changes Sep 18, 2023
View reviewed changes
Copy link

@sabbyanandan sabbyanandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janniks janniks merged commit 58eb3af into main Sep 18, 2023
@janniks janniks deleted the feat/add-hiro-headers branch September 18, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabbyanandan sabbyanandan sabbyanandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include 'x-hiro-product' in HTTP header
2 participants
@janniks @sabbyanandan