Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add preexisting declaration copy step in build #2110

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Oct 7, 2024

Copy link

github-actions bot commented Oct 7, 2024

Vercel deployment URL: https://stacks-blockchain-5wsia9byd-hirosystems.vercel.app 🚀

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried renaming schema.d.ts to schema.ts?

@janniks
Copy link
Collaborator Author

janniks commented Oct 7, 2024

Renaming also works, and "re"generates the d.ts files, but also creates empty .js files for the .ts files.
TSC apparently isn't meant for using .d.ts files, it only compiles and creates new declaration files.
(Needed both for the types.d.ts and the schmea.d.ts files.)

Tested this out and get the types in my local setup. 🙌

@janniks janniks marked this pull request as ready for review October 7, 2024 14:03
Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@janniks janniks changed the title build: add preexisting declaration copy step in build fix: add preexisting declaration copy step in build Oct 7, 2024
@janniks janniks merged commit 2b6aa6a into develop Oct 7, 2024
28 checks passed
@janniks janniks deleted the fix/update-client-types branch October 7, 2024 17:23
blockstack-devops pushed a commit that referenced this pull request Oct 11, 2024
## [8.1.0-beta.2](v8.1.0-beta.1...v8.1.0-beta.2) (2024-10-11)

### Bug Fixes

* add declaration copy step in build ([#2110](#2110)) ([2b6aa6a](2b6aa6a))
@blockstack-devops
Copy link

🎉 This PR is included in version 8.1.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

blockstack-devops pushed a commit that referenced this pull request Oct 16, 2024
## [8.1.0](v8.0.4...v8.1.0) (2024-10-16)

### Features

* add block etag ([#2103](#2103)) ([66e6800](66e6800))
* add cache handler for principal activity including mempool transactions ([#2100](#2100)) ([2370c21](2370c21))
* add principal cache etag to account endpoints ([#2097](#2097)) ([28e9864](28e9864))
* return estimated balance in account balance endpoints ([#2104](#2104)) ([e217cea](e217cea))

### Bug Fixes

* add declaration copy step in build ([#2110](#2110)) ([2b6aa6a](2b6aa6a))
* prune and restore mempool transactions with equal nonces for the same sender ([#2091](#2091)) ([1ce75de](1ce75de))
* randomize key order for testnet stx faucet transactions ([#2120](#2120)) ([f7265f9](f7265f9))
* update mempool garbage collection logic for 3.0 ([#2117](#2117)) ([8b10b69](8b10b69))
* use total_count CTE and return it with the parsed results ([#2073](#2073)) ([bb30911](bb30911))
@blockstack-devops
Copy link

🎉 This PR is included in version 8.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Types for new API client aren't working.
3 participants