Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: why did my tx fail #1928

Merged
merged 1 commit into from
Dec 5, 2024
Merged

feat: why did my tx fail #1928

merged 1 commit into from
Dec 5, 2024

Conversation

He1DAr
Copy link
Collaborator

@He1DAr He1DAr commented Dec 4, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Display logs from why-did-my-tx-fail for failed txs

Issue ticket number and link

closes #1929

Checklist:

  • I have performed a self-review of my code.
  • I have tested the change on desktop and mobile.
  • I have added thorough tests where applicable.
  • I've added analytics and error logging where applicable.

Screenshots (if appropriate):

image

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 8:36pm
hiro-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 8:36pm

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/app/txid/[txId]/TxAlerts.tsx 0.00% 11 Missing and 1 partial ⚠️
src/app/txid/[txId]/useWhyDidMyTxFail.ts 0.00% 8 Missing ⚠️
src/app/txid/[txId]/Alert.tsx 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@He1DAr He1DAr merged commit a443ca0 into main Dec 5, 2024
14 of 17 checks passed
@He1DAr He1DAr deleted the feat/why-did-my-tx-fail branch December 5, 2024 16:46
@blockstack-devops
Copy link

🎉 This PR is included in version 1.233.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@diwakergupta
Copy link
Member

@He1DAr how are you testing this? I just picked a random recent txn and the error message isn't very helpful (I'd say it's borderline misleading actually) -- I think we might want to do some iteration with the backend API, manually work through the common failure types and make sure the API returns useful responses cc/ @janniks

Screenshot 2024-12-05 at 1 03 10 PM

@He1DAr
Copy link
Collaborator Author

He1DAr commented Dec 5, 2024

@diwakergupta more examples of errors:

image
image

Some logs are confusing or user-unfriendly. We'll be looking into improving the logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Display logs from why-did-my-tx-fail for failed txs
4 participants