Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/signer id page #1886

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Feat/signer id page #1886

merged 1 commit into from
Nov 15, 2024

Conversation

BLuEScioN
Copy link
Collaborator

@BLuEScioN BLuEScioN commented Oct 30, 2024 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Adds the signer id page
We are waiting on the API for the data for the stats panel on the right

Figma - https://www.figma.com/design/31q1g27k69z1yXb6r6vrRD/Stacks-Explorer-Working-File?node-id=9664-20852&node-type=canvas&t=PVJNUe8s2skW3xi9-0

Issue ticket number and link

#1878

Checklist:

  • I have performed a self-review of my code.
  • I have tested the change on desktop and mobile.
  • I have added thorough tests where applicable.
  • I've added analytics and error logging where applicable.

Screenshots (if appropriate):

@BLuEScioN BLuEScioN requested a review from He1DAr October 30, 2024 23:03
@vercel Vercel
Copy link

vercel bot commented Oct 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 5:43pm
hiro-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 5:43pm

@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0.59172% with 336 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...rc/app/signer/[signerKey]/StackingHistoryTable.tsx 0.00% 52 Missing ⚠️
src/app/signers/data/UseSigner.ts 0.00% 50 Missing ⚠️
...pp/signer/[signerKey]/AssociatedAddressesTable.tsx 0.00% 26 Missing ⚠️
src/app/signers/data/UseSignerAddresses.ts 0.00% 24 Missing ⚠️
src/app/signer/[signerKey]/SignerSummary.tsx 0.00% 23 Missing ⚠️
src/app/signers/SignersTable.tsx 0.00% 22 Missing and 1 partial ⚠️
src/app/signer/[signerKey]/skeleton.tsx 0.00% 20 Missing ⚠️
src/app/signer/[signerKey]/PageClient.tsx 0.00% 18 Missing and 1 partial ⚠️
src/app/signer/[signerKey]/SignerStats.tsx 0.00% 18 Missing ⚠️
src/app/signers/data/useSigners.ts 0.00% 17 Missing ⚠️
... and 14 more

📢 Thoughts on this report? Let us know!

@BLuEScioN BLuEScioN force-pushed the feat/signer-id-page branch from 36c1eb9 to 52b3110 Compare November 4, 2024 15:31
@BLuEScioN BLuEScioN force-pushed the feat/signer-id-page branch from 52b3110 to 64ad792 Compare November 4, 2024 17:17
@BLuEScioN BLuEScioN force-pushed the feat/signer-id-page branch from 64ad792 to febd17b Compare November 4, 2024 17:32
@BLuEScioN BLuEScioN force-pushed the feat/signer-id-page branch from febd17b to 09a6f64 Compare November 8, 2024 00:38
@BLuEScioN BLuEScioN force-pushed the feat/signer-id-page branch from 09a6f64 to 98221fb Compare November 8, 2024 00:39
@BLuEScioN BLuEScioN force-pushed the feat/signer-id-page branch from 98221fb to cacef8d Compare November 8, 2024 21:29
He1DAr
He1DAr requested changes Nov 11, 2024
View reviewed changes
src/app/signer/[signerKey]/AssociatedAddressesTable.tsx Outdated Show resolved Hide resolved
src/app/signer/[signerKey]/AssociatedAddressesTable.tsx Outdated Show resolved Hide resolved
src/app/signer/[signerKey]/AssociatedAddressesTable.tsx Outdated Show resolved Hide resolved
src/app/signer/[signerKey]/CycleSortFilter.tsx Show resolved Hide resolved
src/app/signer/[signerKey]/PageClient.tsx Outdated Show resolved Hide resolved
src/app/signers/data/UseSignerAddresses.ts Outdated Show resolved Hide resolved
src/app/signers/data/UseSignerAddresses.ts Outdated Show resolved Hide resolved
src/app/signers/data/UseSignerAddresses.ts Show resolved Hide resolved
src/app/signers/data/signer-metrics-hooks.ts Outdated Show resolved Hide resolved
src/app/signers/data/useSigners.ts Show resolved Hide resolved
@He1DAr
Copy link
Collaborator

He1DAr commented Nov 11, 2024

image
we might wanna make these cards same width on smaller screen (unless this is intentional)

@He1DAr
Copy link
Collaborator

He1DAr commented Nov 11, 2024

image
maybe we truncate the signer key even more on mobile to allow more width to the table?

@BLuEScioN BLuEScioN requested a review from He1DAr November 12, 2024 22:13
@BLuEScioN
Copy link
Collaborator Author

image we might wanna make these cards same width on smaller screen (unless this is intentional)

Can you make a separate issue for this? This PR is for the signer id page

@BLuEScioN
Copy link
Collaborator Author

image maybe we truncate the signer key even more on mobile to allow more width to the table?

Can you make a separate issue for this? This PR is for signer id page

@BLuEScioN BLuEScioN merged commit 1486573 into main Nov 15, 2024
14 of 17 checks passed
@BLuEScioN BLuEScioN deleted the feat/signer-id-page branch November 15, 2024 17:49
@blockstack-devops
Copy link

🎉 This PR is included in version 1.228.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@He1DAr He1DAr He1DAr approved these changes

Assignees
No one assigned
Labels
released
Projects
Stacks Explorer
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BLuEScioN @He1DAr @blockstack-devops