Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/blocklist loading #1689

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Fix/blocklist loading #1689

merged 1 commit into from
Jun 24, 2024

Conversation

BLuEScioN
Copy link
Collaborator

@BLuEScioN BLuEScioN commented Jun 21, 2024

Fixes all these issues, plus some other ones I found

closes #1651

@BLuEScioN BLuEScioN requested a review from He1DAr June 21, 2024 21:06
Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hiro-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 5:44pm

@BLuEScioN BLuEScioN force-pushed the fix/blocklist-loading branch from b44bd81 to 784d438 Compare June 24, 2024 17:42
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 32.58427% with 60 lines in your changes missing coverage. Please review.

Project coverage is 18.73%. Comparing base (fe45771) to head (784d438).
Report is 5 commits behind head on main.

Files Patch % Lines
...nents/BlockList/BlocksPage/BlocksPageBlockList.tsx 7.14% 12 Missing and 1 partial ⚠️
...omponents/BlockList/HomePage/HomePageBlockList.tsx 7.14% 12 Missing and 1 partial ⚠️
..._components/BlockList/Grouped/BlockListGrouped.tsx 8.33% 11 Missing ⚠️
src/common/utils/time-utils.ts 0.00% 4 Missing ⚠️
...ts/BlockList/HomePage/HomePageBlockListGrouped.tsx 0.00% 3 Missing ⚠️
.../BlockList/HomePage/HomePageBlockListUngrouped.tsx 0.00% 3 Missing ⚠️
...ponents/BlockList/Ungrouped/BlockListUngrouped.tsx 25.00% 3 Missing ⚠️
...lockList/BlocksPage/BlocksPageBlockListGrouped.tsx 33.33% 2 Missing ⚠️
...ckList/BlocksPage/BlocksPageBlockListUngrouped.tsx 33.33% 2 Missing ⚠️
src/app/_components/BlockList/Grouped/skeleton.tsx 50.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1689      +/-   ##
==========================================
+ Coverage   17.67%   18.73%   +1.05%     
==========================================
  Files         470      472       +2     
  Lines        8261     8302      +41     
  Branches     1776     1788      +12     
==========================================
+ Hits         1460     1555      +95     
+ Misses       6575     6521      -54     
  Partials      226      226              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BLuEScioN BLuEScioN merged commit 9c26cd3 into main Jun 24, 2024
15 of 17 checks passed
@BLuEScioN BLuEScioN deleted the fix/blocklist-loading branch June 24, 2024 22:07
@blockstack-devops
Copy link

🎉 This PR is included in version 1.185.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Find a better way to show blocks per space of time
3 participants