-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/signers map2 #1658
Feat/signers map2 #1658
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0e45f74
to
2248267
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1658 +/- ##
==========================================
- Coverage 17.77% 17.46% -0.31%
==========================================
Files 464 468 +4
Lines 8106 8198 +92
Branches 1743 1760 +17
==========================================
- Hits 1441 1432 -9
- Misses 6448 6542 +94
- Partials 217 224 +7 ☔ View full report in Codecov by Sentry. |
src/app/signers/SignersMap.tsx
Outdated
> | ||
<TileLayer | ||
// url="https://{s}.basemaps.cartocdn.com/light_nolabels/{z}/{x}/{y}{r}.png" | ||
// url="https://{s}.basemaps.cartocdn.com/rastertiles/light_nolabels/{z}/{x}/{y}{r}.png" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving these as the mapbox needs an api key and if we need to quickly switch to another basemap because we have reached the mapbox free request threshold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG! Left a few nits/questions.
🎉 This PR is included in version 1.183.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Adds signers map
Implements signer page redesigns
Resolves #1621
Figma: https://www.figma.com/design/31q1g27k69z1yXb6r6vrRD/Stacks-Explorer-Working-File?node-id=8009-86244&m=dev