Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/signers map2 #1658

Merged
merged 27 commits into from
Jun 13, 2024
Merged

Feat/signers map2 #1658

merged 27 commits into from
Jun 13, 2024

Conversation

BLuEScioN
Copy link
Collaborator

@BLuEScioN BLuEScioN commented Jun 6, 2024

@BLuEScioN BLuEScioN requested a review from He1DAr June 6, 2024 20:52
Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hiro-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 6:52pm

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 4.02930% with 262 lines in your changes missing coverage. Please review.

Project coverage is 17.46%. Comparing base (82ee550) to head (522aab1).
Report is 1 commits behind head on main.

Files Patch % Lines
src/app/signers/SignersMap.tsx 0.00% 108 Missing and 5 partials ⚠️
src/app/signers/SignersMapComponent.tsx 0.00% 38 Missing and 1 partial ⚠️
src/app/signers/SignerDistributionLegend.tsx 6.06% 29 Missing and 2 partials ⚠️
src/app/signers/SignerDistributionPieChart.tsx 21.62% 25 Missing and 4 partials ⚠️
src/app/signers/skeleton.tsx 0.00% 11 Missing ⚠️
src/app/signers/useSignerLocations.ts 0.00% 9 Missing ⚠️
src/app/signers/SignerDistribution.tsx 0.00% 7 Missing ⚠️
src/app/signers/SignersDistributionFilter.tsx 0.00% 7 Missing ⚠️
src/app/signers/SignersTable.tsx 0.00% 6 Missing ⚠️
src/common/utils/utils.ts 20.00% 4 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1658      +/-   ##
==========================================
- Coverage   17.77%   17.46%   -0.31%     
==========================================
  Files         464      468       +4     
  Lines        8106     8198      +92     
  Branches     1743     1760      +17     
==========================================
- Hits         1441     1432       -9     
- Misses       6448     6542      +94     
- Partials      217      224       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

>
<TileLayer
// url="https://{s}.basemaps.cartocdn.com/light_nolabels/{z}/{x}/{y}{r}.png"
// url="https://{s}.basemaps.cartocdn.com/rastertiles/light_nolabels/{z}/{x}/{y}{r}.png"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving these as the mapbox needs an api key and if we need to quickly switch to another basemap because we have reached the mapbox free request threshold

ghost

This comment was marked as duplicate.

Copy link
Collaborator

@He1DAr He1DAr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG! Left a few nits/questions.

@BLuEScioN BLuEScioN merged commit 9234c55 into main Jun 13, 2024
13 of 17 checks passed
@BLuEScioN BLuEScioN deleted the feat/signers-map2 branch June 13, 2024 18:55
@blockstack-devops
Copy link

🎉 This PR is included in version 1.183.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Location data view for the Signer Dashboard
3 participants