Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/blocklist #1641

Merged
merged 15 commits into from
Jun 18, 2024
Merged

Fix/blocklist #1641

merged 15 commits into from
Jun 18, 2024

Conversation

BLuEScioN
Copy link
Collaborator

@BLuEScioN BLuEScioN commented May 28, 2024

closes #1603

Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hiro-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 5:36pm

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 25.61983% with 90 lines in your changes missing coverage. Please review.

Project coverage is 17.67%. Comparing base (9234c55) to head (d7bd161).
Report is 4 commits behind head on main.

Files Patch % Lines
...components/BlockList/data/useBlockListBtcBlocks.ts 0.00% 25 Missing and 2 partials ⚠️
..._components/BlockList/Grouped/BlockListGrouped.tsx 4.16% 23 Missing ⚠️
...ponents/BlockList/Ungrouped/BlockListUngrouped.tsx 10.00% 9 Missing ⚠️
src/app/_components/BlockList/data/utils.ts 0.00% 6 Missing ⚠️
...s/BlockList/data/useBlocksPageBlockListGrouped.tsx 0.00% 4 Missing ⚠️
.../BlockList/data/useBlocksPageBlockListUngrouped.ts 0.00% 4 Missing ⚠️
..._components/BlockList/data/useHomePageBlockList.ts 0.00% 4 Missing ⚠️
src/common/queries/useBurnBlock.ts 0.00% 4 Missing ⚠️
src/app/_components/BlockList/utils.ts 90.00% 1 Missing and 1 partial ⚠️
...lockList/BlocksPage/BlocksPageBlockListGrouped.tsx 0.00% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1641      +/-   ##
==========================================
+ Coverage   17.46%   17.67%   +0.20%     
==========================================
  Files         468      470       +2     
  Lines        8198     8262      +64     
  Branches     1760     1776      +16     
==========================================
+ Hits         1432     1460      +28     
- Misses       6542     6576      +34     
- Partials      224      226       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@He1DAr He1DAr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Left a few comments.

@BLuEScioN BLuEScioN merged commit fe45771 into main Jun 18, 2024
15 of 17 checks passed
@BLuEScioN BLuEScioN deleted the fix/blocklist branch June 18, 2024 14:27
@blockstack-devops
Copy link

🎉 This PR is included in version 1.185.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Fix missing/static data on blocklist
3 participants