Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show receipt time on transaction page #1227

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

dragnoir
Copy link
Contributor

@dragnoir dragnoir commented Jul 7, 2023

Close #1030

On the transaction details page, for pending transactions (mempool), I added a new component for receipt time labeled "Broadcasted"

Capture d'écran 2023-07-07 233318

@vercel
Copy link

vercel bot commented Jul 7, 2023

@dragnoir is attempting to deploy a commit to the Hiro Systems Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Jul 7, 2023

CLA assistant check
All committers have signed the CLA.

@andresgalante andresgalante requested a review from He1DAr July 11, 2023 13:06
Copy link
Member

@andresgalante andresgalante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dragnoir, thanks for the contribution! This is great!

After running your branch, I see an alignment issue where the time doesn't align with the other items at the top, since it has a margin-left: 16px

Can you review that, please?

@He1DAr can you take a look at this this one, please?

@dragnoir
Copy link
Contributor Author

Thank you @andresgalante, margin left 16px removed

Copy link
Member

@andresgalante andresgalante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dragnoir excellent! Thanks for the change!

🙏 Please squash your commits

This PR is good from my side. I'll let @He1DAr review and merge it.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #1227 (59dbfca) into main (b4e827f) will decrease coverage by 16.92%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

❗ Current head 59dbfca differs from pull request most recent head 1eeab5e. Consider uploading reports for the commit 1eeab5e to get more accurate results

@@            Coverage Diff             @@
##             main   #1227       +/-   ##
==========================================
- Coverage   23.05%   6.14%   -16.92%     
==========================================
  Files         453     382       -71     
  Lines        6635    5775      -860     
  Branches     1695    1435      -260     
==========================================
- Hits         1530     355     -1175     
- Misses       4933    5244      +311     
- Partials      172     176        +4     
Files Changed Coverage Δ
src/app/txid/[txid]/ContractCall/TxDetails.tsx 0.00% <0.00%> (ø)
src/app/txid/[txid]/TxDetails/Broadcasted.tsx 0.00% <0.00%> (ø)

... and 201 files with indirect coverage changes

@He1DAr
Copy link
Collaborator

He1DAr commented Jul 25, 2023

Awesome @dragnoir! Please fix linting so that we can proceed with shipping it.

@He1DAr
Copy link
Collaborator

He1DAr commented Jul 25, 2023

Also, wondering if you could add a snapshot test for src/app/txid/[txid]/TxDetails/Broadcasted.tsx. This would be amazing!

@He1DAr He1DAr merged commit 3d5f1e8 into hirosystems:main Sep 20, 2023
3 of 5 checks passed
@blockstack-devops
Copy link

🎉 This PR is included in version 1.121.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Show receipt time or age for mempool txs on transaction page
5 participants