feat(signers-map2): addresssing pr feedback

hirosystems · Jun 13, 2024 · 2d99ca7 · 2d99ca7
1 parent e746950
commit 2d99ca7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/src/app/signers/SignersHeader.tsx b/src/app/signers/SignersHeader.tsx
@@ -68,13 +68,6 @@ export function SignersHeaderLayout({
           </Flex>
           <Flex
             flexDirection={['column', 'column', 'row', 'row', 'row']}
-            // gridTemplateColumns={[
-            //   '100%',
-            //   '100%',
-            //   'repeat(3, 1fr)',
-            //   'repeat(3, 1fr)',
-            //   'repeat(3, 1fr)',
-            // ]}
             width="100%"
             height="100%"
             gap={4}

diff --git a/src/app/signers/SignersMap.tsx b/src/app/signers/SignersMap.tsx
@@ -195,15 +195,18 @@ const MarkerClickHandler = ({ markerLatLng }: { markerLatLng: MarkerLatLng | und
   const map = useMap();
 
   const prevMarkerLatLng = useRef<MarkerLatLng | undefined>(markerLatLng);
+
+  useEffect(() => {
+    prevMarkerLatLng.current = markerLatLng;
+  }, [markerLatLng]);
+
+  // A new marker is clicked if the previous marker is undefined and the current marker is defined, or if the lat/lng of the current marker is different from the previous marker
   const newMarkerClicked =
     (prevMarkerLatLng.current === undefined && markerLatLng !== undefined) ||
     (prevMarkerLatLng.current &&
       markerLatLng &&
       prevMarkerLatLng.current.lat !== markerLatLng.lat) ||
     (prevMarkerLatLng.current && markerLatLng && prevMarkerLatLng.current.lng !== markerLatLng.lng);
-  useEffect(() => {
-    prevMarkerLatLng.current = markerLatLng;
-  }, [markerLatLng]);
 
   useEffect(() => {
     if (!newMarkerClicked) return;
@@ -358,8 +361,6 @@ export function SignersMap({
         maxBounds={BOUNDS}
       >
         <TileLayer
-          // url="https://{s}.basemaps.cartocdn.com/light_nolabels/{z}/{x}/{y}{r}.png"
-          // url="https://{s}.basemaps.cartocdn.com/rastertiles/light_nolabels/{z}/{x}/{y}{r}.png"
           url={mapUrl}
           noWrap={true}
           minZoom={1}