Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynseq to plugins list #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

101arrowz
Copy link

Adds higlass-dynseq to the list of plugin tracks.

Side note: should the plugin data fetcher developed alongside this track (higlass-multi-tileset) be added as well?

Copy link
Member

@flekschas flekschas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Happy to merge this but I think the description and image could be optimized a bit. Do you want to address this first?

"url": "https://github.com/kundajelab/higlass-dynseq#readme",
"title": "DynSeq Track",
"description": "Display a dynamic sequence in HiGlass.",
"image": "https://user-images.githubusercontent.com/29579245/127757191-244d2d33-e13f-4e30-b80e-f05f70134ba4.png",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion but I would trim the image to be closer in its aspect ratio to the container's aspect ratio: https://higlass.io/plugins

Otherwise it's hard too see properly.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be left as is for now and updated later? The sequence plugin does the same thing.

plugins.json Outdated Show resolved Hide resolved
@flekschas
Copy link
Member

I wonder if it could be helpful to add the multi-tileset data fetcher plugin here as well. @pkerpedjiev What do you think? Since the page is just called Plugins I think plugin data fetchers would fit here as well.

@pkerpedjiev
Copy link
Member

I wonder if it could be helpful to add the multi-tileset data fetcher plugin here as well. @pkerpedjiev What do you think? Since the page is just called Plugins I think plugin data fetchers would fit here as well.

Yes, definitely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants