Make useIdiomaticEndpoints default to true #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends on higherkindness/skeuomorph#342. Also cleans up the Model by removing unused classes, and updates the tests and documentation.
L-Lavigne
added
documentation
L-Lavigne
requested review from
cb372,
pepegar,
BenFradet,
dmarticus,
juanpedromoreno and
dzanot
juanpedromoreno
approved these changes
Oct 10, 2020
| @@ -103,6 +103,7 @@ final case class AvroSrcGenerator( | |||
| }) | |||
| .map(generateFrom(_, serializationType)) | |||
|
|
|||
| //TODO: implement this using higherkindness.skeuomorph.mu.Protocol.fromAvroProtocol, as is done in ProtoSrcGenerator | |||
There was a problem hiding this comment.
This is probably part of #101, right?
There was a problem hiding this comment.
Oh, I was just making a note of the discrepancy and forgot there was an issue to address this. :-)
There was a problem hiding this comment.
I'm rebasing #101 off of this in anticipation of yours being merged first :D
| @@ -155,7 +155,7 @@ object SrcGenPlugin extends AutoPlugin { | |||
| } | |||
| }, | |||
| muSrcGenCompressionType := NoCompressionGen, | |||
| muSrcGenIdiomaticEndpoints := false, | |||
| muSrcGenIdiomaticEndpoints := true, | |||
There was a problem hiding this comment.
We'll probably need to update this section in the mu-scala docs 👍
There was a problem hiding this comment.
Indeed, I've got a documentation PR for mu-scala here: higherkindness/mu-scala#1026
dzanot
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93 via higherkindness/skeuomorph#342 and the resulting Skeuomorph release 0.0.26.
Also cleans up the Model by removing unused classes, and updates the tests and documentation.