This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Skeuomorph Integration - Part 1 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # modules/common/src/main/scala/higherkindness/compendium/models/Protocol.scala # modules/server/src/main/scala/higherkindness/compendium/Main.scala # modules/server/src/main/scala/higherkindness/compendium/http/RootService.scala
# Conflicts: # build.sbt # modules/server/src/main/scala/higherkindness/compendium/core/CompendiumService.scala # modules/server/src/main/scala/higherkindness/compendium/db/DBService.scala # modules/server/src/main/scala/higherkindness/compendium/http/RootService.scala # modules/server/src/main/scala/higherkindness/compendium/storage/FileStorage.scala # modules/server/src/main/scala/higherkindness/compendium/storage/Storage.scala # modules/server/src/test/scala/higherkindness/compendium/CompendiumArbitrary.scala # modules/server/src/test/scala/higherkindness/compendium/core/CompendiumServiceSpec.scala # modules/server/src/test/scala/higherkindness/compendium/core/CompendiumServiceStub.scala # modules/server/src/test/scala/higherkindness/compendium/db/DBServiceStub.scala # modules/server/src/test/scala/higherkindness/compendium/storage/FileStorageSpec.scala # modules/server/src/test/scala/higherkindness/compendium/storage/StorageStub.scala
# Conflicts: # build.sbt
JesusMtnez
previously approved these changes
Jul 8, 2019
modules/common/src/main/scala/higherkindness/compendium/models/idlNames.scala
Outdated
Show resolved
Hide resolved
modules/server/src/main/scala/higherkindness/compendium/storage/FileStorage.scala
Outdated
Show resolved
Hide resolved
modules/server/src/main/scala/higherkindness/compendium/db/PgDBService.scala
Outdated
Show resolved
Hide resolved
modules/server/src/test/scala/higherkindness/compendium/db/DBServiceStub.scala
Outdated
Show resolved
Hide resolved
JesusMtnez
dismissed
their stale review
I wanted to send the comments, not to approve
JesusMtnez
reviewed
Jul 8, 2019
JesusMtnez
approved these changes
Jul 8, 2019
juanpedromoreno
approved these changes
Jul 8, 2019
modules/common/src/main/scala/higherkindness/compendium/models/IdlNames.scala
Outdated
Show resolved
Hide resolved
modules/server/src/main/scala/higherkindness/compendium/core/CompendiumService.scala
Outdated
Show resolved
Hide resolved
modules/server/src/main/scala/higherkindness/compendium/http/RootService.scala
Show resolved
Hide resolved
Co-Authored-By: Juan Pedro Moreno <[email protected]>
tzimisce012
reviewed
Jul 8, 2019
modules/server/src/main/scala/higherkindness/compendium/http/RootService.scala
Show resolved
Hide resolved
modules/server/src/main/scala/higherkindness/compendium/parser/utils.scala
Show resolved
Hide resolved
tzimisce012
approved these changes
Jul 8, 2019
bilki
reviewed
Jul 8, 2019
modules/server/src/main/scala/higherkindness/compendium/db/queries/metas.scala
Outdated
Show resolved
Hide resolved
modules/server/src/main/scala/higherkindness/compendium/http/QueryParams.scala
Outdated
Show resolved
Hide resolved
modules/server/src/main/scala/higherkindness/compendium/parser/ProtocolParser.scala
Outdated
Show resolved
Hide resolved
modules/server/src/main/scala/higherkindness/compendium/parser/ProtocolParserService.scala
Outdated
Show resolved
Hide resolved
modules/server/src/main/scala/higherkindness/compendium/storage/FileStorage.scala
Outdated
Show resolved
Hide resolved
modules/server/src/test/scala/higherkindness/compendium/CompendiumArbitrary.scala
Show resolved
Hide resolved
…/ProtocolParser.scala Co-Authored-By: Roberto Serrano <[email protected]>
bilki
approved these changes
Jul 8, 2019
…/compendium into sc-skeuomorph-integration
pirita
reviewed
Jul 9, 2019
modules/common/src/main/scala/higherkindness/compendium/models/IdlNames.scala
Outdated
Show resolved
Hide resolved
pirita
reviewed
Jul 9, 2019
modules/server/src/main/resources/db/migration/V1__add_protocols_table.sql
Outdated
Show resolved
Hide resolved
JesusMtnez
reviewed
Jul 9, 2019
modules/server/src/main/scala/higherkindness/compendium/db/PgDBService.scala
Outdated
Show resolved
Hide resolved
JesusMtnez
reviewed
Jul 9, 2019
modules/server/src/main/scala/higherkindness/compendium/core/CompendiumService.scala
Outdated
Show resolved
Hide resolved
JesusMtnez
reviewed
Jul 9, 2019
modules/server/src/main/scala/higherkindness/compendium/db/PgDBService.scala
Outdated
Show resolved
Hide resolved
pirita
reviewed
Jul 9, 2019
modules/server/src/test/scala/higherkindness/compendium/parser/protocols.scala
Outdated
Show resolved
Hide resolved
JesusMtnez
reviewed
Jul 9, 2019
modules/server/src/main/scala/higherkindness/compendium/models/DBModels.scala
Outdated
Show resolved
Hide resolved
JesusMtnez
reviewed
Jul 9, 2019
modules/server/src/main/scala/higherkindness/compendium/models/DBModels.scala
Outdated
Show resolved
Hide resolved
JesusMtnez
reviewed
Jul 9, 2019
modules/server/src/main/scala/higherkindness/compendium/db/DBService.scala
Outdated
Show resolved
Hide resolved
bilki
approved these changes
Jul 11, 2019
| } | ||
|
|
||
| override def parse(protocol: FullProtocol, target: Target): F[ParserResult] = | ||
| skeuomorphParse(protocol, target).map(_.asRight[ParserError]) |
There was a problem hiding this comment.
Why ParserResult as return type if we never handle the error from skeuomorphParse and are just piping the correct FullProtocol into it? Are we going to use ParserResult left side in the future?
There was a problem hiding this comment.
Good one. My idea is to handle the error in the future. We need to storage the new protocol generated and for that, I'll use the result of the parser
pirita
approved these changes
Jul 15, 2019
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I'm adding new content to Compendium. Some changes had to be done in order to make the Skeuomorph integration easier. Also, in this PR I'm adding the capability to convert Avro and Protobuf schemas to Mu.
This is not the final version of the Skeuomorph integration but I think is recommendable to merge this to make the code more maintainable and avoid tons of conflicts every time I merge from master 🙂
IDLs Conversions