Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated Checkout screen from XML to Compose #189

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Conversation

p42rthicle
Copy link
Contributor

Migrated Checkout feature to jetpack compose (Fixes #174)

Thing to note:

  • Didnt see removeItem, minusItem or plusItem callbacks being implemented anyway even in the viewmodels so those onClick Listeners in LineItemModel item is a TODO

@hieuwu
Copy link
Owner

hieuwu commented Oct 5, 2023

Migrated Checkout feature to jetpack compose (Fixes #174)

Thing to note:

  • Didnt see removeItem, minusItem or plusItem callbacks being implemented anyway even in the viewmodels so those onClick Listeners in LineItemModel item is a TODO

Actually In checkout screen we don't need to implement the minus, plus, click or remove. It's Ok to leave it as is Patt. Great work 👍 Thank you for your contribution

@hieuwu hieuwu self-requested a review October 5, 2023 04:04
@hieuwu hieuwu removed their request for review October 5, 2023 04:05
local.properties Outdated Show resolved Hide resolved
@p42rthicle
Copy link
Contributor Author

Okay great!
No problem
Glad to contribute

@hieuwu hieuwu merged commit 55970c0 into hieuwu:main Oct 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Checkout feature to Jetpack Compose
2 participants