Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrated NotificationSettings fragment to NotificationSettingsScreen Composable #188

Merged
merged 2 commits into from
Oct 4, 2023
Merged

migrated NotificationSettings fragment to NotificationSettingsScreen Composable #188

merged 2 commits into from
Oct 4, 2023

Conversation

Yashraj254
Copy link
Contributor

@Yashraj254 Yashraj254 commented Oct 3, 2023 •
edited
Loading

NotificationSettings in Jetpack Compose (Fixes #175 )

  • Implemented NotificationSettings Screen Composable
  • Deleted fragment_notification_settings.xml file

Screenshot

Screenshot_2023-10-04-04-28-01-43_4c7a1d9749c5968f7f9bd1b0ef18adf7 1

@Yashraj254
Copy link
Contributor Author

hey @hieuwu , though this should work as expected, i am facing problems with authentication part as it keeps giving me request time out error, also my email rate limit is exceeded, i am unable to test it properly. it will be helpful if you can take a look at it.

@hieuwu
Copy link
Owner

hieuwu commented Oct 4, 2023

hey @hieuwu , though this should work as expected, i am facing problems with authentication part as it keeps giving me request time out error, also my email rate limit is exceeded, i am unable to test it properly. it will be helpful if you can take a look at it.

Great work Yash. I’ll take a look and test it. No worries

@Yashraj254
Copy link
Contributor Author

Yashraj254 commented Oct 4, 2023 •
edited
Loading

@hieuwu thankyou.😊

@hieuwu hieuwu self-requested a review October 4, 2023 10:07
@hieuwu hieuwu merged commit 80127c3 into hieuwu:main Oct 4, 2023
2 checks passed
@hieuwu
Copy link
Owner

hieuwu commented Oct 5, 2023

Hi just a question @Yashraj254 . Did you create account on Supabase?

@Yashraj254
Copy link
Contributor Author

@hieuwu yes i did.

@Yashraj254 Yashraj254 deleted the migrating_notification_settings_to_compose branch October 5, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hieuwu hieuwu hieuwu approved these changes

Assignees

@Yashraj254 Yashraj254

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Notification Settings feature to Jetpack Compose
2 participants
@Yashraj254 @hieuwu