-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix
: AccountTransactions int64
props change to strings
#303
fix
: AccountTransactions int64
props change to strings
#303
Conversation
…dels Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
…ctor Signed-off-by: ivaylogarnev-limechain <[email protected]>
…ectory, refactored a bit the DevelopmentProcess.md Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
fix
: AccountTransactions int64
props change to strings
Signed-off-by: ivaylogarnev-limechain <[email protected]>
docs/test-specifications/crypto-service/AccountCreateTransaction.md
Outdated
Show resolved
Hide resolved
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having trouble running these tests individually by themselves.. when I try to run npm test src/tests/crypto-service/test-account-create-transaction.ts
it still runs everything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works with C++ server
…lso updated README' -s -S ' Signed-off-by: ivaylogarnev-limechain <[email protected]>
8e7b7de
to
4fd909d
Compare
I have modified the package.json file and added an |
Works on JS & GO servers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
This PR converts account transaction number properties to strings and introduces enums for better organization.
Related issue(s):
#284
Checklist