Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AccountTransactions int64 props change to strings #303

Merged

Conversation

ivaylogarnev-limechain
Copy link
Contributor

@ivaylogarnev-limechain ivaylogarnev-limechain commented Dec 5, 2024

Description:
This PR converts account transaction number properties to strings and introduces enums for better organization.

Related issue(s):
#284

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ivaylogarnev-limechain ivaylogarnev-limechain changed the title 00284 update types in account transactions fix: AccountTransactions int64 props change to strings Dec 5, 2024
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Copy link
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having trouble running these tests individually by themselves.. when I try to run npm test src/tests/crypto-service/test-account-create-transaction.ts it still runs everything

Copy link
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with C++ server

…lso updated README' -s -S

'

Signed-off-by: ivaylogarnev-limechain <[email protected]>
@ivaylogarnev-limechain ivaylogarnev-limechain force-pushed the 00284-update-types-in-account-transactions branch from 8e7b7de to 4fd909d Compare December 10, 2024 07:34
@ivaylogarnev-limechain
Copy link
Contributor Author

Having trouble running these tests individually by themselves.. when I try to run npm test src/tests/crypto-service/test-account-create-transaction.ts it still runs everything

I have modified the package.json file and added an npm run test:file command. This new command allows to specify a particular file for testing, while the default npm run test command continues to run all tests. README updated too.

@ivaylogarnev-limechain
Copy link
Contributor Author

Works on JS & GO servers

Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivaylogarnev-limechain ivaylogarnev-limechain merged commit 497c2c1 into main Dec 12, 2024
2 checks passed
@ivaylogarnev-limechain ivaylogarnev-limechain deleted the 00284-update-types-in-account-transactions branch December 12, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants