TCK: Refactor - code duplication, helper functions
#277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome repeatable params in constant, refactored based on those changes for accountService tests Signed-off-by: ivaylogarnev-limechain <[email protected]>
…fyTokenKey and moved custom fee logic to the helpers too Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
rwalworth
reviewed
Nov 13, 2024
…c in front of every retryError Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
rwalworth
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR refactors the code to reduce duplication and improve maintainability. It introduces several helper functions to streamline logic and enhance readability. Additionally, some constants were added to make the code more organized and easier to manage. These changes aim to improve both the clarity and scalability of the code.
Related issue(s):
#260
Checklist