Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Mirror node parsing and mocha context binding #307

Closed
ivaylogarnev-limechain opened this issue Dec 10, 2024 · 0 comments · Fixed by #309
Closed

bug: Mirror node parsing and mocha context binding #307

ivaylogarnev-limechain opened this issue Dec 10, 2024 · 0 comments · Fixed by #309
Assignees
Milestone

Comments

@ivaylogarnev-limechain
Copy link
Contributor

ivaylogarnev-limechain commented Dec 10, 2024

  1. Replace all arrow functions in Mocha tests with function declarations to ensure proper access to Mocha's this context, enabling features like this.skip() and this.timeout(). This fix addresses failing tests caused by the lack of this binding in arrow functions.
  2. Introduce BigInt parser for handling Mirror Node data response to accurately process large integer values. This resolves issues where the default JSON parser cannot handle numbers exceeding JavaScript's maximum safe integer limit making some tests to fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants