Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mirror node response parser and arrow function replacement #309

Merged
merged 17 commits into from
Dec 13, 2024

Conversation

ivaylogarnev-limechain
Copy link
Contributor

Description:
This PR replaces arrow functions in Mocha tests with function declarations to ensure proper access to this context, fixing failing tests and introduces a BigInt parser for handling large integers in Mirror Node data responses, resolving issues with numbers exceeding JavaScript's safe integer limit.

Related issue(s):
#307

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…ectory, refactored a bit the DevelopmentProcess.md

Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
…lso updated README' -s -S

'

Signed-off-by: ivaylogarnev-limechain <[email protected]>
…nction to declarations

Signed-off-by: ivaylogarnev-limechain <[email protected]>
Copy link
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivaylogarnev-limechain ivaylogarnev-limechain linked an issue Dec 13, 2024 that may be closed by this pull request
@ivaylogarnev-limechain ivaylogarnev-limechain merged commit 53c6d09 into main Dec 13, 2024
2 checks passed
@ivaylogarnev-limechain ivaylogarnev-limechain deleted the 00307-bug-mirror-node-data-mocha-context branch December 13, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Mirror node parsing and mocha context binding
3 participants