Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for Networking Configuration (PR) #515

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Tests for Networking Configuration (PR) #515

merged 5 commits into from
Oct 31, 2023

Conversation

deyanzz
Copy link
Contributor

@deyanzz deyanzz commented Oct 9, 2023 •
edited
Loading

Description:

This PR adds some Unit tests for the Network class.

Related issue(s):

Fixes: #166

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@deyanzz deyanzz linked an issue Oct 9, 2023 that may be closed by this pull request
Tests for Networking Configuration #166
Closed
@deyanzz deyanzz self-assigned this Oct 9, 2023
@deyanzz deyanzz force-pushed the 00166-test-for-networking-configuration branch 2 times, most recently from 692469a to 1932b5a Compare October 18, 2023 11:16
@deyanzz deyanzz marked this pull request as ready for review October 20, 2023 14:06
@deyanzz deyanzz requested a review from rwalworth October 20, 2023 14:07
rwalworth
rwalworth approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a lot more can be added to this but LGTM for now.

@deyanzz deyanzz force-pushed the 00166-test-for-networking-configuration branch from cbb0a03 to 6eb0924 Compare October 25, 2023 11:01
@deyanzz deyanzz force-pushed the 00166-test-for-networking-configuration branch from 6eb0924 to 11b8685 Compare October 26, 2023 10:57
@deyanzz deyanzz requested a review from rwalworth October 31, 2023 15:32
@deyanzz deyanzz merged commit fb33c96 into main Oct 31, 2023
2 checks passed
@deyanzz deyanzz deleted the 00166-test-for-networking-configuration branch October 31, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwalworth rwalworth rwalworth approved these changes

Assignees

@deyanzz deyanzz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests for Networking Configuration
2 participants
@deyanzz @rwalworth