Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for min and max backoff time (PR) #510

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Tests for min and max backoff time (PR) #510

merged 3 commits into from
Oct 4, 2023

Conversation

deyanzz
Copy link
Contributor

@deyanzz deyanzz commented Oct 2, 2023 •
edited
Loading

Description:

This PR adds more integration tests to check the minimum and maximum backoff time configuration for:

  • Client

Related issue(s):

Fixes: #373

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@deyanzz deyanzz self-assigned this Oct 2, 2023
@deyanzz deyanzz linked an issue Oct 2, 2023 that may be closed by this pull request
Tests for min and max backoff time #373
Closed
@deyanzz deyanzz force-pushed the 00373-tests-for-min-and-max-backoff-time branch from d5d6cb3 to 135b283 Compare October 4, 2023 08:37
@deyanzz deyanzz marked this pull request as ready for review October 4, 2023 14:32
@deyanzz deyanzz requested a review from rwalworth October 4, 2023 14:36
@deyanzz
373: Updated tests
d9ddd93 
Signed-off-by: Deyan Zhekov <[email protected]>
rwalworth
rwalworth approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@rwalworth rwalworth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should probably be a part of unit tests since it's just testing that the values get set in the Client, but they can be moved over at a later time

@rwalworth rwalworth merged commit 7f106bb into main Oct 4, 2023
2 checks passed
@rwalworth rwalworth deleted the 00373-tests-for-min-and-max-backoff-time branch October 4, 2023 15:19
@deyanzz
Copy link
Contributor Author

deyanzz commented Oct 4, 2023

Agree. These tests should be part of the Unit tests suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwalworth rwalworth rwalworth approved these changes

Assignees

@deyanzz deyanzz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests for min and max backoff time
2 participants
@deyanzz @rwalworth