fix: don't fill out accountIdToUpdate if no account ID was provided (…

…#756) Signed-off-by: Rob Walworth <[email protected]>
hiero-ledger · Aug 8, 2024 · 50db0db · 50db0db
1 parent ce3c619
commit 50db0db
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/sdk/main/src/AccountUpdateTransaction.cc b/src/sdk/main/src/AccountUpdateTransaction.cc
@@ -258,7 +258,10 @@ proto::CryptoUpdateTransactionBody* AccountUpdateTransaction::build() const
 {
   auto body = std::make_unique<proto::CryptoUpdateTransactionBody>();
 
-  body->set_allocated_accountidtoupdate(mAccountId.toProtobuf().release());
+  if (!(mAccountId == AccountId()))
+  {
+    body->set_allocated_accountidtoupdate(mAccountId.toProtobuf().release());
+  }
 
   if (mKey)
   {

diff --git a/src/sdk/tests/integration/AccountUpdateTransactionIntegrationTests.cc b/src/sdk/tests/integration/AccountUpdateTransactionIntegrationTests.cc
@@ -31,6 +31,7 @@
 #include "TransactionReceipt.h"
 #include "TransactionResponse.h"
 #include "TransferTransaction.h"
+#include "exceptions/PrecheckStatusException.h"
 #include "exceptions/ReceiptStatusException.h"
 
 #include <gtest/gtest.h>
@@ -158,7 +159,7 @@ TEST_F(AccountUpdateTransactionIntegrationTests, CannotUpdateAccountWithoutAccou
                                                       .sign(privateKey)
                                                       .execute(getTestClient())
                                                       .getReceipt(getTestClient()),
-               ReceiptStatusException); // ACCOUNT_ID_DOES_NOT_EXIST
+               PrecheckStatusException); // ACCOUNT_ID_DOES_NOT_EXIST
 
   // Clean up
   ASSERT_NO_THROW(AccountDeleteTransaction()