fix(bug): Update description setters #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roger Barker <[email protected]>
andrewb1269hg
approved these changes
Nov 15, 2024
jjohannes
deleted the
10-bug-with-assigning-description-field-in-pomxml
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
<description></description>field was not present in the pom.xml file generated for maven central. Needed to update two parts of the field setter:.orElse(provider { project.description })became.orElse(provider(project::getDescription))to actually populate with the project description.orNull()becomes.orElse("")to prevent a null entry on description if it is not present in the other ways