Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/readme #95

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Fix/readme #95

merged 2 commits into from
Feb 16, 2024

Conversation

vpsx
Copy link
Contributor

@vpsx vpsx commented Feb 6, 2024

Description

At present, if someone follows the local dev setup instructions verbatim, the docker-compose file that actually gets run upon docker compose up is the one at the top level of this repo (not either of the docker-compose files in packages/server); that docker-compose file sets environment variables from .env.test, in particular the db username and password. Then upon running the prisma migrate step, there will be db auth errors if the environment variables in that shell are not also set according to .env.test.

I don't know what the intended steps are supposed to be (is the db actually supposed to be spun up from one of the other docker-compose files?) so this was just the quickest path to instructions that don't result in errors; just close this PR if not appropriate

Checklist

  • [x ] This PR can be reviewed in under 30 minutes
  • [x ] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • [x ] I have made corresponding changes to the documentation
  • [x ] I have assigned reviewers to this PR.

@vpsx vpsx requested a review from gregfrasco February 6, 2024 19:21
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 886ad701
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (886ad70) Report Missing Report Missing Report Missing
Head commit (3b67f53) 868 403 46.43%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#95) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@gregfrasco gregfrasco merged commit 8dcf323 into main Feb 16, 2024
5 checks passed
@gregfrasco gregfrasco deleted the fix/readme branch February 16, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants