Support ctrl+hjkl in more apps and command history search #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running fzf or other tools, it's nice if the plugin doesn't move panes or tabs when using the ctrl+h/j/k/l shortcuts, because those tools also use those shortcuts for navigation. This change adds a configuration option to not switch panes or tabs when in the listed disabled apps, by default vim, nvim and fzf. People can add more apps if they need to.
Allow people to control if the plugin is active or not. This can be helpful when the plugin needs to be temporarily disabled when an application uses the ctrl/alt+hjkl keybindings and you wouldn't want the plugin to switch pane or tab. Updated the README with an example use case I ran into myself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! Great plugin!
I ran into some issues with other apps like fzf no longer receiving ctrl-hjkl, and made some changes to make it work better with it. I couldn't figure out a way to detect when ctrl+r would show fzf in the current pane. I don't know if that's even possible. Instead, this solution supports toggling the plugin on and off and document keybinding config to make it work with those other apps.
## Add config to disable plugin for more apps
When running fzf or other tools, it's nice if the plugin doesn't move panes or tabs when using the ctrl+h/j/k/l shortcuts, because those tools also use those shortcuts for navigation.
This change adds a configuration option to not switch panes or tabs when in the listed disabled apps, by default vim, nvim and fzf. People can add more apps if they need to.
Add enable and disable messages
Allow people to control if the plugin is active or not. This can be helpful when the plugin needs to be temporarily disabled when an application uses the ctrl/alt+hjkl keybindings and you wouldn't want the plugin to switch pane or tab.
Updated the README with an example use case I ran into myself.