Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

Commit

Permalink
Split FIXME into multiple multi line comments.
Browse files Browse the repository at this point in the history
FIXME syntax is less flexible on 4.32 according to CI.
  • Loading branch information
lexidor authored and fredemmott committed Mar 28, 2022
1 parent 0884408 commit d8d0729
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/core/XHPAttributeCoercion.php
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public static function CoerceToString(
return (string)$val;
}
if ($val is Stringish) {
/* HH_FIXME[4053] HH_FIXME[4062] HH_FIXME[4128]
/* HH_FIXME[4053] */ /* HH_FIXME[4062] */ /* HH_FIXME[4128]
We know that $val is (not string & Stringish).
This implies StringishObject, so calling __toString() is safe.
StringishObject was added in hhvm 4.118 and this branch targets 4.32+. */
Expand Down

0 comments on commit d8d0729

Please sign in to comment.