Skip to content

Commit

Permalink
Revert D50089378: Multisect successfully blamed "D50089378: Remove ha…
Browse files Browse the repository at this point in the history
…ck modes from Hack tests" for test or build failures

Summary:
This diff is reverting D50089378
D50089378: Remove hack modes from Hack tests by viratyosin has been identified to be causing the following test or build failures:

Tests affected:
- [hphp/hack/test/facebook/write_symbol_info:regression_tests - cases/omega_analyser](https://www.internalfb.com/intern/test/844424983077690/)

Here's the Multisect link:
https://www.internalfb.com/multisect/3260372
Here are the tasks that are relevant to this breakage:

We're generating a revert to back out the changes in this diff, please note the backout may land if someone accepts it.

If you believe this diff has been generated in error you may Commandeer and Abandon it.

Differential Revision: D50206182

fbshipit-source-id: 3da6b0aca3e3e4be03884e58d43364408782f0e9
  • Loading branch information
generatedunixname89002005232357 authored and facebook-github-bot committed Oct 12, 2023
1 parent d9646a6 commit 69ba168
Show file tree
Hide file tree
Showing 56 changed files with 56 additions and 56 deletions.
2 changes: 1 addition & 1 deletion tests/HackLibTestForwardOnlyIterator.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/HackLibTestStringable.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/HackLibTestTraversables.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/RefTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/async/ConditionTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/async/PollTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/async/SemaphoreTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/c/CIntrospectTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/c/COrderTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict

/*
* Copyright (c) 2004-present, Facebook, Inc.
Expand Down
2 changes: 1 addition & 1 deletion tests/c/CReduceTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/c/CSelectTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/dict/DictAsyncTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/dict/DictCombineTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/dict/DictDivideTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/dict/DictIntrospectTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/dict/DictOrderTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/dict/DictSelectTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/dict/DictTransformTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/file/FileTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/file/RelativePathTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/io/BufferedReaderTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/io/MemoryHandleTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/io/PipeTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/keyset/KeysetAsyncTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/keyset/KeysetCombineTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/keyset/KeysetDivideTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/keyset/KeysetIntrospectTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/keyset/KeysetOrderTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/keyset/KeysetSelectTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/keyset/KeysetTransformTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/locale/LocaleTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/math/MathCompareTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/math/MathComputeTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/math/MathConstantsTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/math/MathContainersTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/os/MkdtempTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/os/SpawnTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/random/PseudoRandomTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/random/RandomTestTrait.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/random/SecureRandomTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/regex/RegexTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/str/StrCombineTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/str/StrDivideTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/str/StrFormatTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/str/StrIntrospectTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/str/StrLocaleTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/str/StrSelectTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/str/StrTransformTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/tcp/HSLTCPTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/unix/HSLUnixSocketTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/vec/VecAsyncTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/vec/VecCombineTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/vec/VecDivideTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/vec/VecOrderTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/vec/VecSelectTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down
2 changes: 1 addition & 1 deletion tests/vec/VecTransformTest.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?hh
<?hh // strict
/*
* Copyright (c) 2004-present, Facebook, Inc.
* All rights reserved.
Expand Down

0 comments on commit 69ba168

Please sign in to comment.