Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support --if-private and --if-public #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ForbesLindesay
Copy link

I'm not sure if this is useful or not. After writing I realised that you also need to check that the version numbers are up to date, which can be done using https://github.com/azu/can-npm-publish

In case it is of use. I'll leave this PR here.

@spion
Copy link
Collaborator

spion commented Aug 29, 2019

Not entirely sure but I believe wsrun --if can-npm-publish publish would work here, since can-npm-publish also checks the private field?

@ForbesLindesay
Copy link
Author

That didn't work because yarn seems to run with an odd environment which means can-npm-publish does not manage to check the version number of the published package when it's called as a yarn script. It fails to authenticate properly with the npm registry. This PR doesn't fix that problem anyway, so feel free to close.

@joshgummersall
Copy link

@ForbesLindesay I published a tiny package '@standardlabs/is-private' that provides two commands, 'is-private' and 'is-not-private', both just look at the private field in a package file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants