Document disabling route controller for self-managed networks #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the README appears to provide incomplete instructions when using self-managed networks with HCCM. Per #758 setting
HCLOUD_NETWORKalone isn't enough as HCCM enables the route controller and fails. SettingHCLOUD_NETWORK_ROUTES_ENABLEDto false is also required for the self-managed network scenario.This PR adds that to the documentation, and also offers a tip to enable the
load-balancer.hetzner.cloud/use-private-ipannotation on the K8s service (at least in lieu of full documentation of supported annotations).If there's a valid use case for self-managed network with route controller enabled, please let me know and I"m happy to refine the PR to clarify that.
Fixes #758