Enable lints to prevent unwanted usages of unwrap(), assert! and panic!
#711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`panic!` The `clippy::unwrap_used` lint prevent usage of `.unwrap()` outside of tests: https://rust-lang.github.io/rust-clippy/master/index.html#/unwrap_used The `clippy::panic_in_result_fn` lint prevent usages of `assert!` or `panic!` in functions that already return a `Result`: https://rust-lang.github.io/rust-clippy/master/index.html#/panic_in_result_fn These lints catch cases like #709, #710 and #712. The lints have not been enabled for the integration test modules (since it's pointless, as they only apply to non-test usages), or to the example buildpacks, since it's a lot of boilerplate to add to an example. Very soon we will be able to switch to the upcoming `[lints]` table feature, which will mean the duplication of lint definitions can be avoided entirely: https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#lints
edmorley
force-pushed
the
edmorley/panic-lints
branch
from
bebd998 to
2d6ba6e
Compare
Malax
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
clippy::unwrap_usedlint prevents usage of.unwrap()outside of tests:https://rust-lang.github.io/rust-clippy/master/index.html#/unwrap_used
The
clippy::panic_in_result_fnlint prevents usages ofassert!orpanic!in functions that already return aResult:https://rust-lang.github.io/rust-clippy/master/index.html#/panic_in_result_fn
These lints catch cases like #709, #710 and #712.
The lints have not been enabled for the integration test modules (since using
unwrap()is fine there), or to the example buildpacks, since it's a lot of boilerplate to add to an example.Very soon we will be able to switch to the upcoming
[lints]table feature, which will mean the duplication of lint definitions can be avoided entirely:https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#lints
GUS-W-14413286.