Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GH_TOKEN env to gh CLI invocation #695

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

Malax
Copy link
Member

@Malax Malax commented Oct 6, 2023

gh does not work properly without the GH_TOKEN environment variable. For the double release check, we fail the check if the invocation succeeds. Since the token is missing it will never succeed, making the check a no-op. This PR adds the missing token.

Ref: https://github.com/heroku/libcnb.rs/actions/runs/6299767340/job/17101136605#step:8:13

@Malax Malax requested a review from a team as a code owner October 6, 2023 11:29
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, thank you!

.github/workflows/release.yml Outdated Show resolved Hide resolved
@Malax Malax force-pushed the malax/fix-release-check branch from a645344 to 5d65653 Compare October 6, 2023 13:15
@Malax Malax force-pushed the malax/fix-release-check branch from 5d65653 to 8a72134 Compare October 6, 2023 13:16
@Malax Malax enabled auto-merge (squash) October 6, 2023 13:16
@Malax Malax merged commit 86cf63c into main Oct 6, 2023
4 checks passed
@Malax Malax deleted the malax/fix-release-check branch October 6, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants