package_buildpack() contains an unwrap() in non-test code
#710
Assignees
Labels
Comments
|
There's a lint we can enable to prevent this in the future: |
edmorley
added a commit
that referenced
this issue
Nov 2, 2023
…`panic!` (#711) The `clippy::unwrap_used` lint prevents usage of `.unwrap()` outside of tests: https://rust-lang.github.io/rust-clippy/master/index.html#/unwrap_used The `clippy::panic_in_result_fn` lint prevents usages of `assert!` or `panic!` in functions that already return a `Result`: https://rust-lang.github.io/rust-clippy/master/index.html#/panic_in_result_fn These lints catch cases like #709, #710 and #712. The lints have not been enabled for the integration test modules (since using `unwrap()` is fine there), or to the example buildpacks, since it's a lot of boilerplate to add to an example. Very soon we will be able to switch to the upcoming `[lints]` table feature, which will mean the duplication of lint definitions can be avoided entirely: https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#lints GUS-W-14413286.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#666 introduced an
.unwrap()in non-#[cfg(test)]code, here:libcnb.rs/libcnb-test/src/build.rs
Line 90 in 2698a71
We should never use
.unwrap()apart from in tests.In particular,
package_buildpack()already returns aResult, so this failure mode should be converted to another error variant within it.The text was updated successfully, but these errors were encountered: