-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Prepare release v0.20.0 * Cleanup * Fix lint errors with Rust 1.78 Fixes: ``` warning: the item `TryFrom` is imported redundantly --> libcnb-data/src/buildpack/api.rs:2:5 | 2 | use std::convert::TryFrom; | ^^^^^^^^^^^^^^^^^^^^^ | ::: /Users/emorley/.rustup/toolchains/beta-aarch64-apple-darwin/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:129:13 | 129 | pub use core::prelude::rust_2021::*; | ------------------------ the item `TryFrom` is already defined here | = note: `#[warn(unused_imports)]` on by default warning: the item `TryFrom` is imported redundantly --> libcnb-data/src/buildpack/version.rs:2:5 | 2 | use std::convert::TryFrom; | ^^^^^^^^^^^^^^^^^^^^^ | ::: /Users/emorley/.rustup/toolchains/beta-aarch64-apple-darwin/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:129:13 | 129 | pub use core::prelude::rust_2021::*; | ------------------------ the item `TryFrom` is already defined here warning: `libcnb-data` (lib) generated 2 warnings warning: backticks are unbalanced --> libcnb/src/target.rs:14:9 | 14 | /// CNB `lifecycle` sources this value from the build OCI image's [`architecture` property](https://g... | _________^ 15 | | /// `` | |__________^ | = help: a backtick may be missing a pair = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown = note: `-W clippy::doc-markdown` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::doc_markdown)]` warning: `libcnb` (lib) generated 1 warning warning: assigning the result of `Clone::clone()` may be inefficient --> libcnb-test/tests/integration_test.rs:686:25 | 686 | container_name = container.container_name.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `container_name.clone_from(&container.container_name)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `#[warn(clippy::assigning_clones)]` on by default warning: the item `SbomFormat` is imported redundantly --> libcnb-data/src/buildpack/mod.rs:235:9 | 234 | use super::*; | -------- the item `SbomFormat` is already imported here 235 | use crate::sbom::SbomFormat; | ^^^^^^^^^^^^^^^^^^^^^^^ warning: the item `libcnb_newtype` is imported redundantly --> libcnb-data/src/newtypes.rs:193:9 | 52 | / macro_rules! libcnb_newtype { 53 | | ( 54 | | $path:path, 55 | | $(#[$macro_attributes:meta])* ... | 186 | | }; 187 | | } | |_- the item `libcnb_newtype` is already defined here ... 193 | use super::libcnb_newtype; | ^^^^^^^^^^^^^^^^^^^^^ warning: the item `fs` is imported redundantly --> libherokubuildpack/src/fs.rs:44:9 | 44 | use std::fs; | ^^^^^^^ ... 49 | use super::*; | -------- the item `fs` is already imported here | = note: `#[warn(unused_imports)]` on by default warning: `libcnb-test` (test "integration_test") generated 1 warning (run `cargo clippy --fix --test "integration_test"` to apply 1 suggestion) warning: `libcnb-data` (lib test) generated 4 warnings (2 duplicates) warning: `libherokubuildpack` (lib test) generated 1 warning warning: the item `LayerContentMetadata` is imported redundantly --> libcnb/src/layer/handling.rs:465:47 | 464 | use super::*; | -------- the item `LayerContentMetadata` is already imported here 465 | use crate::data::layer_content_metadata::{LayerContentMetadata, LayerTypes}; | ^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default warning: the item `GenericMetadata` is imported redundantly --> libcnb/src/layer/handling.rs:467:9 | 464 | use super::*; | -------- the item `GenericMetadata` is already imported here ... 467 | use crate::generic::GenericMetadata; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ warning: the item `fs` is imported redundantly --> libcnb/src/layer/handling.rs:472:9 | 464 | use super::*; | -------- the item `fs` is already imported here ... 472 | use std::fs; | ^^^^^^^ warning: the item `fs` is imported redundantly --> libcnb/src/platform.rs:68:9 | 66 | use super::*; | -------- the item `fs` is already imported here 67 | use std::ffi::OsString; 68 | use std::fs; | ^^^^^^^ ``` --------- Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com> Co-authored-by: Ed Morley <[email protected]>
- Loading branch information
1 parent
292762e
commit 78d218e
Showing
23 changed files
with
45 additions
and
50 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
use serde::Deserialize; | ||
use std::convert::TryFrom; | ||
use std::fmt; | ||
use std::fmt::{Display, Formatter}; | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
use serde::Deserialize; | ||
use std::convert::TryFrom; | ||
use std::fmt; | ||
use std::fmt::{Display, Formatter}; | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters