Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source GOFLAGS from environment #561

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Source GOFLAGS from environment #561

merged 2 commits into from
Jul 15, 2024

Conversation

joshwlewis
Copy link
Member

@joshwlewis joshwlewis commented Jun 25, 2024 •
edited
Loading

This allows users to customize their builds a bit more, and do things like heroku config:set GOFLAGS="-pgo=/tmp/profile.pgo" so that PGO may be used.

Fixes #400.

@joshwlewis joshwlewis marked this pull request as ready for review June 25, 2024 18:49
@joshwlewis joshwlewis requested a review from a team as a code owner June 25, 2024 18:49
ypaq
ypaq approved these changes Jun 25, 2024
View reviewed changes
Copy link

@ypaq ypaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@joshwlewis joshwlewis enabled auto-merge (squash) July 15, 2024 16:28
@joshwlewis joshwlewis merged commit 14a68b3 into main Jul 15, 2024
6 checks passed
@joshwlewis joshwlewis deleted the source-go-flags branch July 15, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypaq ypaq ypaq approved these changes

@edmorley edmorley edmorley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Further specifying build flags
3 participants
@joshwlewis @edmorley @ypaq